Issue 11030052: Merge 159680 - It seems that snd_pcm_hw_params_set_* API does not work well any more in the latest …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11030052: Merge 159680 - It seems that snd_pcm_hw_params_set_* API does not work well any more in the latest … (Closed)

Created:
8 years, 2 months ago by no longer working on chromium

Modified:
8 years, 2 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

Merge 159680 - It seems that snd_pcm_hw_params_set_* API does not work well any more in the latest ubuntu like 12.04. My tests show that it will freeze the pulseaudio for a while and get into underrun state. And it seems snd_pcm_set_params works better for the same purpose. This patch also fixes the choppy audio issue for webrtc in ubuntu 12.04. BUG=152232, 153505 TEST=use pepper flash (./out/Debug/chrome -ppapi-flash-path=/your/path/libpepflashplayer.so) open link http://www.youtube.com/watch?v=F7pYHN9iC9I&feature=youtu.be in two tabs, audio should be good. uses apprtc.appspot.com to make a loopback call and verify the audio is good on ubuntu 12.04 Review URL: https://chromiumcodereview.appspot.com/11019010 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160379

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -66 lines)			Patch
	M	media/audio/linux/alsa_wrapper.cc	View		1 chunk	+7 lines, -66 lines	0 comments	Download

Total messages: 1 (0 generated)