Chromium Code Reviews
Help | Chromium Project | Sign in
(71)

Issue 11030052: Merge 159680 - It seems that snd_pcm_hw_params_set_* API does not work well any more in the latest … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by no longer working on chromium
Modified:
2 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 159680 - It seems that snd_pcm_hw_params_set_* API does not work well any more in the latest ubuntu like 12.04. My tests show that it will freeze the pulseaudio for a while and get into underrun state. And it seems snd_pcm_set_params works better for the same purpose. This patch also fixes the choppy audio issue for webrtc in ubuntu 12.04. BUG=152232, 153505 TEST=use pepper flash (./out/Debug/chrome -ppapi-flash-path=/your/path/libpepflashplayer.so) open link http://www.youtube.com/watch?v=F7pYHN9iC9I&feature=youtu.be in two tabs, audio should be good. uses apprtc.appspot.com to make a loopback call and verify the audio is good on ubuntu 12.04 Review URL: https://chromiumcodereview.appspot.com/11019010 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -66 lines) Patch
M media/audio/linux/alsa_wrapper.cc View 1 chunk +7 lines, -66 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 1 (0 generated)
no longer working on chromium
2 years, 5 months ago (2012-10-05 15:18:45 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d