Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1102933002: [DevTools] Use WebLayerTreeView::layerTreeId() for instrumentation. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
kenrb, caseq, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, mlamouri+watch-blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, dcheng, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Use WebLayerTreeView::layerTreeId() for instrumentation. Instead of pushing layer tree id from content, we pull it via WebLayerTreeView. This ensures we can update it exactly when it's changed, and allows to instrument cross-process subframes. BUG=480980 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M Source/web/WebDevToolsAgentImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 4 chunks +13 lines, -2 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M public/platform/WebLayerTreeView.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dgozman
Could you please take a look? Added method implemented in https://codereview.chromium.org/1097353004/.
5 years, 8 months ago (2015-04-24 14:11:35 UTC) #2
kenrb
Why does this need to get updated like this for child frames but not for ...
5 years, 8 months ago (2015-04-24 15:12:41 UTC) #3
dgozman
On 2015/04/24 15:12:41, kenrb wrote: > Why does this need to get updated like this ...
5 years, 8 months ago (2015-04-24 16:48:50 UTC) #4
pfeldman
lgtm
5 years, 8 months ago (2015-04-24 16:59:31 UTC) #5
kenrb
On 2015/04/24 16:48:50, dgozman wrote: > On 2015/04/24 15:12:41, kenrb wrote: > > Why does ...
5 years, 8 months ago (2015-04-24 17:06:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102933002/1
5 years, 8 months ago (2015-04-25 06:46:54 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 16:41:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194438

Powered by Google App Engine
This is Rietveld 408576698