Make aura_demo work on Mac

Make aura_demo work on Mac

Fix a few instances where !Windows is assumed to be Linux.

Chang many instances of !USE_GTK_MESSAGE_PUMP &&
!OS_MACOSX && !OS_ANDROID to just USE_AURA (they are
equivalent now).

Add a very minimal RootWindowHostMac.

Of note is that building with Aura requires running
"gyp_chromium --no-circular-check" (the circular
check is only enabled on Mac, and doesn't work with
Aura).

Also note that the demo does not work properly unless BGRA
support is disabled (in FeatureInfo::InitializeBasicState these
extensions can be disabled).

BUG=331669
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243392

[Ben Goodger (Google), 2013-12-31 03:38:08]

https://codereview.chromium.org/110283005/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/110283005/diff/1/chrome/chrome_browser_ui.gyp...
chrome/chrome_browser_ui.gypi:3269: ['use_aura==1 and OS!="mac"',{
note: we should come up with a better conditional for this block, even if it
means splitting it up.

[ccameron, 2014-01-03 19:17:27]

On 2013/12/31 03:38:08, Ben Goodger (Google) wrote:
> https://codereview.chromium.org/110283005/diff/1/chrome/chrome_browser_ui.gypi
> File chrome/chrome_browser_ui.gypi (right):
> 
>
https://codereview.chromium.org/110283005/diff/1/chrome/chrome_browser_ui.gyp...
> chrome/chrome_browser_ui.gypi:3269: ['use_aura==1 and OS!="mac"',{
> note: we should come up with a better conditional for this block, even if it
> means splitting it up.

Thanks -- working on that. There's also a cycle in the dependency graph in the
.gyp files, which has been taking a very long time to sort out (I'd characterize
gyp as something between write-only and undebuggable).

[ccameron, 2014-01-04 21:40:25]

Thanks! Ptal the current patch.

With respect to --no-circular-check, it turns out that that flag doesn't
work (and isn't enabled) anywhere except non-Aura Mac.

[Ben Goodger (Google), 2014-01-06 17:34:25]

+darin for base

[darin (slow to review), 2014-01-06 17:35:55]

base/ changes LGTM

[Ben Goodger (Google), 2014-01-06 17:37:09]

src/chrome/* and src/ui/* lgtm

https://codereview.chromium.org/110283005/diff/170001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/110283005/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:405: #if defined(USE_AURA) &&
defined(OS_MACOSX)
who's the best person to review this? :-)

[sadrul, 2014-01-06 17:40:08]

A small drive-by question

https://codereview.chromium.org/110283005/diff/170001/ui/aura/env.h
File ui/aura/env.h (right):

https://codereview.chromium.org/110283005/diff/170001/ui/aura/env.h#newcode31
ui/aura/env.h:31: #if defined(USE_AURA)
Do you actually need this ifdef anymore? (also in env.cc)

[ccameron, 2014-01-06 19:05:14]

Thanks!!

https://codereview.chromium.org/110283005/diff/170001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/110283005/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:405: #if defined(USE_AURA) &&
defined(OS_MACOSX)
On 2014/01/06 17:37:10, Ben Goodger (Google) wrote:
> who's the best person to review this? :-)

Oops! Removed this block & updated the CL description (so it's "works if you
remove BGRA support"). I'll figure out the proper solution.

https://codereview.chromium.org/110283005/diff/170001/ui/aura/env.h
File ui/aura/env.h (right):

https://codereview.chromium.org/110283005/diff/170001/ui/aura/env.h#newcode31
ui/aura/env.h:31: #if defined(USE_AURA)
On 2014/01/06 17:40:09, sadrul wrote:
> Do you actually need this ifdef anymore? (also in env.cc)

Good point -- no, it's not needed (I'd been thinking not to break the GTK build
yet, but the GTK build doesn't touch these files).

[commit-bot: I haz the power, 2014-01-07 18:53:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/110283005/630001

[commit-bot: I haz the power, 2014-01-07 21:42:11]

Change committed as 243392