content: Move the remaining source files of webkit/ over here.

content: Move the remaining source files of webkit/ over here.

With this we conclude the removal of webkit/ and the old webkit_glue
layer.

BUG=338338
R=boliu@chromium.org,avi@chromium.org,danakj@chromium.org,piman@chromium.org
TBR=danakj@chromium.org

Committed: https://crrev.com/4de54406fd81a2c781f982d4ce5c9160089cb2af
Cr-Commit-Position: refs/heads/master@{#327975}

[tfarina, 2015-04-27 00:35:40]

The last one. Bye, bye webkit!

Bo -> android
Avi -> content
Dana -> webkit

[Avi (use Gerrit), 2015-04-27 01:52:07]

lgtm

🎉🎈

[danakj, 2015-04-27 17:02:20]

LGTM

[boliu, 2015-04-27 17:07:51]

content/browser/android/in_process lgtm

[piman, 2015-04-27 23:27:55]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2015-04-27 23:27:56]

LGTM. So long webkit/, you served us well.

[tfarina, 2015-04-28 01:48:58]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102673007/40001

[commit-bot: I haz the power, 2015-04-28 01:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:55:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2015-04-28 01:58:18]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102673007/40001

[commit-bot: I haz the power, 2015-04-28 03:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 03:30:23]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[tfarina, 2015-04-28 03:33:27]

Bo, how do I fix that?

Got LicenseError "License file not found. Either add a file named LICENSE,
import upstream's COPYING if available, or add a 'License File:' line to
README.chromium with the appropriate path." while scanning third_party/WebKit

[boliu, 2015-04-28 03:35:54]

boliu@chromium.org changed reviewers:
+ mnaganov@chromium.org

[boliu, 2015-04-28 03:35:54]

On 2015/04/28 03:33:27, tfarina wrote:
> Bo, how do I fix that?
> 
> Got LicenseError "License file not found. Either add a file named LICENSE,
> import upstream's COPYING if available, or add a 'License File:' line to
> README.chromium with the appropriate path." while scanning third_party/WebKit

I don't actually know... +mnaganov

[jamesr, 2015-04-28 03:41:07]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-04-28 03:41:07]

It looks like that comes from here:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/licenses.py&...

We have a LICENSE file at the root of the Blink repo that's pulled in to
//third_party/WebKit/LICENSE.  I'm not sure if that's the same for the purposes
of this, however.

[tfarina, 2015-04-28 19:08:24]

Mikhail, friendly ping?

James, do you think I should update the path in
https://code.google.com/p/chromium/codesearch#chromium/src/tools/licenses.py&...

Would that unlock this patch (i.e., allow cq to land it)?

[jamesr, 2015-04-28 19:14:37]

I'm not knowledgeable enough about the license script requirements to know how
to proceed here, sorry.

[piman, 2015-04-28 19:41:34]

On Tue, Apr 28, 2015 at 12:14 PM, <jamesr@chromium.org> wrote:

> I'm not knowledgeable enough about the license script requirements to know
> how
> to proceed here, sorry.
>
> https://codereview.chromium.org/1102673007/


AIUI it's there to generate about:credits.

So it sounds like we should keep this file somewhere and point to the new
location.

Antoine

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-04-28 21:48:47]

On Tue, Apr 28, 2015 at 4:41 PM, Antoine Labour <piman@chromium.org> wrote:

>
>
> On Tue, Apr 28, 2015 at 12:14 PM, <jamesr@chromium.org> wrote:
>
>> I'm not knowledgeable enough about the license script requirements to
>> know how
>> to proceed here, sorry.
>>
>> https://codereview.chromium.org/1102673007/
>
>
> AIUI it's there to generate about:credits.
>
> So it sounds like we should keep this file somewhere and point to the new
> location.
>
> Would content/LICENSE or even blink/LICENSE be fine?


> Antoine
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[piman, 2015-04-28 21:52:10]

On Tue, Apr 28, 2015 at 2:48 PM, Thiago Farina <tfarina@chromium.org> wrote:

>
>
> On Tue, Apr 28, 2015 at 4:41 PM, Antoine Labour <piman@chromium.org>
> wrote:
>
>>
>>
>> On Tue, Apr 28, 2015 at 12:14 PM, <jamesr@chromium.org> wrote:
>>
>>> I'm not knowledgeable enough about the license script requirements to
>>> know how
>>> to proceed here, sorry.
>>>
>>> https://codereview.chromium.org/1102673007/
>>
>>
>> AIUI it's there to generate about:credits.
>>
>> So it sounds like we should keep this file somewhere and point to the new
>> location.
>>
>> Would content/LICENSE or even blink/LICENSE be fine?
>

blink/LICENSE seems the best, but maybe check with an owner there?

Antoine


>
>
>> Antoine
>>
>
>
>
> --
> Thiago Farina
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2015-04-28 21:59:35]

dpranke@chromium.org changed reviewers:
+ dannyb@google.com

[Dirk Pranke, 2015-04-28 21:59:47]

On 2015/04/28 21:52:10, piman (Very slow to review) wrote:
> blink/LICENSE seems the best, but maybe check with an owner there?

I have no idea what the right thing to do is here. We might have to check w/
legal.

+dannyb, can you advise?

[chromium-reviews, 2015-04-28 22:06:19]

Happy to help, but I need a bit more context. I've tried to look at the
thread, but it doesn't quite give me enough info about what you guys are
doing and why :)


On Tue, Apr 28, 2015 at 2:59 PM <dpranke@chromium.org> wrote:

> On 2015/04/28 21:52:10, piman (Very slow to review) wrote:
> > blink/LICENSE seems the best, but maybe check with an owner there?
>
> I have no idea what the right thing to do is here. We might have to check
> w/
> legal.
>
> +dannyb, can you advise?
>
>
> https://codereview.chromium.org/1102673007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-04-28 22:08:40]

On Tue, Apr 28, 2015 at 7:06 PM, Daniel Berlin <dannyb@google.com> wrote:

> Happy to help, but I need a bit more context. I've tried to look at the
> thread, but it doesn't quite give me enough info about what you guys are
> doing and why :)
>
> webkit/LICENSE is getting removed and android_webview licenses tool is
complaining about it. So we are trying to find a new home for it and
blink/LICENSE was suggested.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-04-28 22:13:20]

ah. So is it the same code, just new location?


On Tue, Apr 28, 2015 at 3:08 PM Thiago Farina <tfarina@chromium.org> wrote:

> On Tue, Apr 28, 2015 at 7:06 PM, Daniel Berlin <dannyb@google.com> wrote:
>
>> Happy to help, but I need a bit more context. I've tried to look at the
>> thread, but it doesn't quite give me enough info about what you guys are
>> doing and why :)
>>
>> webkit/LICENSE is getting removed and android_webview licenses tool is
> complaining about it. So we are trying to find a new home for it and
> blink/LICENSE was suggested.
>
> --
> Thiago Farina
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-04-28 22:27:27]

On Tue, Apr 28, 2015 at 7:13 PM, Daniel Berlin <dannyb@google.com> wrote:

> ah. So is it the same code, just new location?
>
> Well, the code left in webkit/ isn't really from WebKit.

But yes, the code is the same, just now is being transferred to content/.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[piman, 2015-04-28 23:32:26]

On Tue, Apr 28, 2015 at 3:27 PM, Thiago Farina <tfarina@chromium.org> wrote:

>
>
> On Tue, Apr 28, 2015 at 7:13 PM, Daniel Berlin <dannyb@google.com> wrote:
>
>> ah. So is it the same code, just new location?
>>
>> Well, the code left in webkit/ isn't really from WebKit.
>
> But yes, the code is the same, just now is being transferred to content/.
>

The LICENSE file in webkit/ today is used to represent the license for
third_party/WebKit, as is represented in about:credits - not, actually, the
code in webkit/ which is (was) chromium code to glue WebKit into content/.
third_party/WebKit is blink, a fork of WebKit, and so carries over the
multiple license terms (BSD, LGPL 2, LGPL 2.1). webkit/LICENSE predates the
blink fork (2010), I assume because at the time Webkit didn't have a
LICENSE file (and we were pulling directly from upstream), so we needed
some place to put it for licenses.py. third_party/WebKit/LICENSE, which is
the standard chromium license (BSD-style), was added post-fork (2014),
intending (AIUI) to cover new code (and non-otherwise-noted-LGPL pre-fork
code).

Now that we're removing webkit/ because all the code has moved, we need a
place to put this webkit/LICENSE file, which, again, has nothing to do with
the code that was in webkit/. Now that I think of it, maybe the best would
be to have it in third_party/WebKit, under a different name
(LICENSE_FOR_ABOUT_CREDITS or whatever), and point licenses.py to that file.

Antoine



>
> --
> Thiago Farina
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-04-28 23:35:37]

Your thoughts on this SGTM.


On Tue, Apr 28, 2015 at 4:32 PM Antoine Labour <piman@chromium.org> wrote:

> On Tue, Apr 28, 2015 at 3:27 PM, Thiago Farina <tfarina@chromium.org>
> wrote:
>
>>
>>
>> On Tue, Apr 28, 2015 at 7:13 PM, Daniel Berlin <dannyb@google.com> wrote:
>>
>>> ah. So is it the same code, just new location?
>>>
>>> Well, the code left in webkit/ isn't really from WebKit.
>>
>> But yes, the code is the same, just now is being transferred to content/.
>>
>
> The LICENSE file in webkit/ today is used to represent the license for
> third_party/WebKit, as is represented in about:credits - not, actually, the
> code in webkit/ which is (was) chromium code to glue WebKit into content/.
> third_party/WebKit is blink, a fork of WebKit, and so carries over the
> multiple license terms (BSD, LGPL 2, LGPL 2.1). webkit/LICENSE predates the
> blink fork (2010), I assume because at the time Webkit didn't have a
> LICENSE file (and we were pulling directly from upstream), so we needed
> some place to put it for licenses.py. third_party/WebKit/LICENSE, which is
> the standard chromium license (BSD-style), was added post-fork (2014),
> intending (AIUI) to cover new code (and non-otherwise-noted-LGPL pre-fork
> code).
>
> Now that we're removing webkit/ because all the code has moved, we need a
> place to put this webkit/LICENSE file, which, again, has nothing to do with
> the code that was in webkit/. Now that I think of it, maybe the best would
> be to have it in third_party/WebKit, under a different name
> (LICENSE_FOR_ABOUT_CREDITS or whatever), and point licenses.py to that file.
>
> Antoine
>
>
>
>>
>> --
>> Thiago Farina
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-04-28 23:42:37]

On Tue, Apr 28, 2015 at 8:32 PM, Antoine Labour <piman@chromium.org> wrote:

>
>
> On Tue, Apr 28, 2015 at 3:27 PM, Thiago Farina <tfarina@chromium.org>
> wrote:
>
>>
>>
>> On Tue, Apr 28, 2015 at 7:13 PM, Daniel Berlin <dannyb@google.com> wrote:
>>
>>> ah. So is it the same code, just new location?
>>>
>>> Well, the code left in webkit/ isn't really from WebKit.
>>
>> But yes, the code is the same, just now is being transferred to content/.
>>
>
> The LICENSE file in webkit/ today is used to represent the license for
> third_party/WebKit, as is represented in about:credits - not, actually, the
> code in webkit/ which is (was) chromium code to glue WebKit into content/.
> third_party/WebKit is blink, a fork of WebKit, and so carries over the
> multiple license terms (BSD, LGPL 2, LGPL 2.1). webkit/LICENSE predates the
> blink fork (2010), I assume because at the time Webkit didn't have a
> LICENSE file (and we were pulling directly from upstream), so we needed
> some place to put it for licenses.py. third_party/WebKit/LICENSE, which is
> the standard chromium license (BSD-style), was added post-fork (2014),
> intending (AIUI) to cover new code (and non-otherwise-noted-LGPL pre-fork
> code).
>
> Now that we're removing webkit/ because all the code has moved, we need a
> place to put this webkit/LICENSE file, which, again, has nothing to do with
> the code that was in webkit/. Now that I think of it, maybe the best would
> be to have it in third_party/WebKit, under a different name
> (LICENSE_FOR_ABOUT_CREDITS or whatever), and point licenses.py to that file.
>
> Thanks Antoine.

I will prepare a change for adding LICENSE_FOR_ABOUT_CREDITS to
third_party/WebKit/, after it lands and get rolled into Chromium, I will
point licenses.py to it, then I should be able to go back to this patch.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-04-29 03:02:38]

OK, I have uploaded the patch for Blink here
https://codereview.chromium.org/1114793002/.

[mnaganov (inactive), 2015-05-01 16:19:35]

Sorry, I was actually OOO for 4 days, but didn't update my status. What you
are doing makes sense to me, so please go ahead.

On Tue, Apr 28, 2015 at 8:02 PM, <tfarina@chromium.org> wrote:

> OK, I have uploaded the patch for Blink here
> https://codereview.chromium.org/1114793002/.
>
> https://codereview.chromium.org/1102673007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-05-01 19:27:54]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-05-01 19:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
boliu@chromium.org, piman@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1102673007/#ps60001
(title: "REBASE")

[commit-bot: I haz the power, 2015-05-01 19:28:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102673007/60001

[commit-bot: I haz the power, 2015-05-01 20:44:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-01 20:45:44]

Patchset 4 (id:??) landed as
https://crrev.com/4de54406fd81a2c781f982d4ce5c9160089cb2af
Cr-Commit-Position: refs/heads/master@{#327975}