Refactor createTexture and onCreateTexture

Refactor createTexture and onCreateTexture

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b0e1be207f6b5a5346641b7b675bb9bd1993f9df

[egdaniel, 2015-04-22 20:02:43]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[egdaniel, 2015-04-22 20:02:44]

Some general cleanup to move some non gl specific code up to the base class

[bsalomon, 2015-04-22 20:11:11]

https://codereview.chromium.org/1102663002/diff/1/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1102663002/diff/1/src/gpu/GrGpu.cpp#newcode97
src/gpu/GrGpu.cpp:97: (!SkIsPow2(desc.fWidth) || !SkIsPow2(desc.fHeight))) {
descCopy x2 ?


minor suggestion: I think it is slightly less error prone to give the prefixed
name to the const parameter passed in (origDesc, paramDesc, ...) and immediately
assign it to the local var so that accidental references to the unmodified const
param are easy to notice in the function.

[egdaniel, 2015-04-22 20:20:27]

https://codereview.chromium.org/1102663002/diff/1/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1102663002/diff/1/src/gpu/GrGpu.cpp#newcode97
src/gpu/GrGpu.cpp:97: (!SkIsPow2(desc.fWidth) || !SkIsPow2(desc.fHeight))) {
On 2015/04/22 20:11:11, bsalomon wrote:
> descCopy x2 ?
> 
> 
> minor suggestion: I think it is slightly less error prone to give the prefixed
> name to the const parameter passed in (origDesc, paramDesc, ...) and
immediately
> assign it to the local var so that accidental references to the unmodified
const
> param are easy to notice in the function.

Done.

[bsalomon, 2015-04-22 20:20:52]

lgtm

[egdaniel, 2015-04-22 20:22:04]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-04-22 20:22:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102663002/20001

[commit-bot: I haz the power, 2015-04-22 20:27:46]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b0e1be207f6b5a5346641b7b675bb9bd1993f9df

[jvanverth1, 2015-04-22 20:28:13]

https://codereview.chromium.org/1102663002/diff/20001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1102663002/diff/20001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:41: 
I thought we were deprecating the use of anonymous namespaces, and using
'static' instead.

[tomhudson, 2015-04-23 17:14:01]

On 2015/04/22 20:28:13, jvanverth1 wrote:
>
https://codereview.chromium.org/1102663002/diff/20001/src/gpu/GrGpu.cpp#newco...
> src/gpu/GrGpu.cpp:41: 
> I thought we were deprecating the use of anonymous namespaces, and using
> 'static' instead.

Reasons? I thought the opposite...