Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 11026067: Merge 130313 - Crash when calling document.open during unload (Closed)

Created:
8 years, 2 months ago by abarth-chromium
Modified:
8 years, 2 months ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 130313 - Crash when calling document.open during unload https://bugs.webkit.org/show_bug.cgi?id=98287 Reviewed by Nate Chapin. Source/WebCore: Calling document.open results in us nulling out m_documentLoader. This code doesn't properly handle that case and crashes. Test: fast/parser/document-open-in-unload.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): LayoutTests: Test that we don't crash when calling document.open during the unload event. * fast/parser/document-open-in-unload-expected.txt: Added. * fast/parser/document-open-in-unload.html: Added. TBR=abarth@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/fast/parser/document-open-in-unload.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/parser/document-open-in-unload-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
abarth-chromium
8 years, 2 months ago (2012-10-05 16:14:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698