Chromium Code Reviews
Help | Chromium Project | Sign in
(652)

Issue 11026061: Parallelize ninja generation when GYP_PARALLEL=1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by dmazzoni
Modified:
1 year, 6 months ago
Reviewers:
Nico, scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Parallelize ninja generation when GYP_PARALLEL=1.

This is a really easy approach, parallelizing by configs (Debug/Release).
It's probably not worth parallelizing this step much more because there's
some overhead and the total time of this step isn't that large.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Lint Patch
M pylib/gyp/__init__.py View 3 chunks +5 lines, -5 lines 0 comments ? errors Download
M pylib/gyp/generator/ninja.py View 3 chunks +15 lines, -3 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 11
dmazzoni
This should shave a few more seconds off the total time.
1 year, 6 months ago #1
Nico
Wait, isn't GYP_PARALLEL implemented already? What does it currently parallelize? How much does this change ...
1 year, 6 months ago #2
Ami Fischman
drive-by FWIW, this patch doesn't make a difference on my z620/gprecise/ninja setup. Before CL: fischman@fischman-linux ...
1 year, 6 months ago #3
dmazzoni
On 2012/10/05 06:45:25, Nico wrote: > Wait, isn't GYP_PARALLEL implemented already? What does it currently ...
1 year, 6 months ago #4
Nico
Ok. Any reason to not just always do this, instead of having it behind a ...
1 year, 6 months ago #5
dmazzoni
On 2012/10/05 07:09:34, Nico wrote: > Ok. > > Any reason to not just always ...
1 year, 6 months ago #6
Nico
On 2012/10/05 07:14:17, Dominic Mazzoni wrote: > On 2012/10/05 07:09:34, Nico wrote: > > Ok. ...
1 year, 6 months ago #7
scottmg
Super, thanks! (this was at my behest because windows spends about 4x the time in ...
1 year, 6 months ago #8
dmazzoni
On 2012/10/05 16:29:43, scottmg wrote: > Non-parallel: 57.8s > Loading-only parallel: 46.0s > Loading and ...
1 year, 6 months ago #9
scottmg
On 2012/10/08 17:02:46, Dominic Mazzoni wrote: > On 2012/10/05 16:29:43, scottmg wrote: > > Non-parallel: ...
1 year, 6 months ago #10
Nico
1 year, 6 months ago #11
lgtm

Maybe you can add a TODO with a link to the bug for removing the option
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6