Chromium Code Reviews
Help | Chromium Project | Sign in
(157)

Issue 11026061: Parallelize ninja generation when GYP_PARALLEL=1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by dmazzoni_ooo_until_july_13
Modified:
2 years, 8 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Parallelize ninja generation when GYP_PARALLEL=1. This is a really easy approach, parallelizing by configs (Debug/Release). It's probably not worth parallelizing this step much more because there's some overhead and the total time of this step isn't that large.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M pylib/gyp/__init__.py View 3 chunks +5 lines, -5 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 3 chunks +15 lines, -3 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 11 (0 generated)
dmazzoni_ooo_until_july_13
This should shave a few more seconds off the total time.
2 years, 9 months ago (2012-10-05 06:42:47 UTC) #1
Nico
Wait, isn't GYP_PARALLEL implemented already? What does it currently parallelize? How much does this change ...
2 years, 9 months ago (2012-10-05 06:45:25 UTC) #2
Ami GONE FROM CHROMIUM
drive-by FWIW, this patch doesn't make a difference on my z620/gprecise/ninja setup. Before CL: fischman@fischman-linux ...
2 years, 9 months ago (2012-10-05 06:52:18 UTC) #3
dmazzoni_ooo_until_july_13
On 2012/10/05 06:45:25, Nico wrote: > Wait, isn't GYP_PARALLEL implemented already? What does it currently ...
2 years, 9 months ago (2012-10-05 07:06:49 UTC) #4
Nico
Ok. Any reason to not just always do this, instead of having it behind a ...
2 years, 9 months ago (2012-10-05 07:09:34 UTC) #5
dmazzoni_ooo_until_july_13
On 2012/10/05 07:09:34, Nico wrote: > Ok. > > Any reason to not just always ...
2 years, 9 months ago (2012-10-05 07:14:17 UTC) #6
Nico
On 2012/10/05 07:14:17, Dominic Mazzoni wrote: > On 2012/10/05 07:09:34, Nico wrote: > > Ok. ...
2 years, 9 months ago (2012-10-05 08:14:09 UTC) #7
scottmg (ooo jul1 to aug6)
Super, thanks! (this was at my behest because windows spends about 4x the time in ...
2 years, 9 months ago (2012-10-05 16:29:43 UTC) #8
dmazzoni_ooo_until_july_13
On 2012/10/05 16:29:43, scottmg wrote: > Non-parallel: 57.8s > Loading-only parallel: 46.0s > Loading and ...
2 years, 8 months ago (2012-10-08 17:02:46 UTC) #9
scottmg (ooo jul1 to aug6)
On 2012/10/08 17:02:46, Dominic Mazzoni wrote: > On 2012/10/05 16:29:43, scottmg wrote: > > Non-parallel: ...
2 years, 8 months ago (2012-10-08 17:11:22 UTC) #10
Nico
2 years, 8 months ago (2012-10-14 01:13:56 UTC) #11
lgtm

Maybe you can add a TODO with a link to the bug for removing the option
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d