Fill in FrameNavigationEntries for auto subframe navigations.

Fill in FrameNavigationEntries for auto subframe navigations.

BUG=236848
TEST=NavigationController* tests pass in --site-per-process mode.

Committed: https://crrev.com/6da51f96a9b748b5118e6fd9aa7abab88a0fdccc
Cr-Commit-Position: refs/heads/master@{#329912}

[Charlie Reis, 2015-05-14 16:52:07]

creis@chromium.org changed reviewers:
+ avi@chromium.org

[Charlie Reis, 2015-05-14 16:52:08]

Avi, can you take a look?

I'm talking with Nate about how to use something like Blink's frame sequence
number or unique name instead (similar to HistoryNode in the renderer process),
but we can get by with FrameTreeNode ID for now to let us keep making progress.

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_entry_impl.cc (right):

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_entry_impl.cc:67: // TODO(creis): Pass in
FTN ID?  How?
Oops, I'll remove this TODO, since it's covered elsewhere.

[Avi (use Gerrit), 2015-05-14 18:01:11]

Are you assuming sane initialization of an int and bool in a struct? :(

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2171:
params.page_id = 1;
params.nav_entry_id = 0;
params.did_create_new_entry = false;

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2218:
params.page_id = 1;
params.nav_entry_id = 0;
params.did_create_new_entry = false;

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_entry_impl.cc (right):

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_entry_impl.cc:493: for (size_t i = 0; i <
parent_node->children.size(); i++)
for (auto& child : parent_node->children) ?

[Charlie Reis, 2015-05-14 19:00:38]

Thanks!  New patch up.

On 2015/05/14 18:01:11, Avi wrote:
> Are you assuming sane initialization of an int and bool in a struct? :(

Oops, no, that was written (and then copy/pasted) before you added those to
params.  Thanks for catching it!

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2171:
params.page_id = 1;
On 2015/05/14 18:01:11, Avi wrote:
> params.nav_entry_id = 0;
> params.did_create_new_entry = false;

Done.

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2218:
params.page_id = 1;
On 2015/05/14 18:01:11, Avi wrote:
> params.nav_entry_id = 0;
> params.did_create_new_entry = false;

Done.

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_entry_impl.cc (right):

https://codereview.chromium.org/1102563003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_entry_impl.cc:493: for (size_t i = 0; i <
parent_node->children.size(); i++)
On 2015/05/14 18:01:11, Avi wrote:
> for (auto& child : parent_node->children) ?

Done.

[Avi (use Gerrit), 2015-05-14 19:02:54]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2015-05-14 19:02:55]

lgtm

[Avi (use Gerrit), 2015-05-14 19:03:00]

The CQ bit was unchecked by avi@chromium.org

[Charlie Reis, 2015-05-14 19:13:23]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2015-05-14 19:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102563003/80001

[commit-bot: I haz the power, 2015-05-14 19:57:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-14 19:58:30]

Patchset 5 (id:??) landed as
https://crrev.com/6da51f96a9b748b5118e6fd9aa7abab88a0fdccc
Cr-Commit-Position: refs/heads/master@{#329912}