content/browser/frame_host/navigation_controller_impl.cc - Issue 1102563003: Fill in FrameNavigationEntries for auto subframe navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1102563003: Fill in FrameNavigationEntries for auto subframe navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/frame_navigation_entry.cc ('k') | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 08555a3f9c5714cf6bfab46bbce3a8887d95cdc7..69e812e472e579b453c572863ffb152d5c776301 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1472,11 +1472,9 @@ bool NavigationControllerImpl::RendererDidNavigateAutoSubframe(

switches::kSitePerProcess)) {

// This may be a "new auto" case where we add a new FrameNavigationEntry, or

// it may be a "history auto" case where we update an existing one.

- int frame_tree_node_id = rfh->frame_tree_node()->frame_tree_node_id();

NavigationEntryImpl* last_committed = GetLastCommittedEntry();

- last_committed->AddOrUpdateFrameEntry(frame_tree_node_id,

- rfh->GetSiteInstance(),

- params.url,

+ last_committed->AddOrUpdateFrameEntry(rfh->frame_tree_node(),

+ rfh->GetSiteInstance(), params.url,

params.referrer);

}