Issue 1102373002: Fix counters() separator serialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1102373002: Fix counters() separator serialization (Closed)

Created:
5 years, 8 months ago by rwlbuis

Modified:
5 years, 7 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Fix counters() separator serialization The nested counters construction counters() states that the separator part is a <string>: http://www.w3.org/TR/CSS2/syndata.html#counter So when serializing it follow the spec by calling serializeString: http://dev.w3.org/csswg/cssom/#serialize-a-string Behavior matches Firefox. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194561

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	LayoutTests/fast/css/counters/counter-cssText.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/css/counters/counter-cssText-expected.txt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102373002/20001

5 years, 7 months ago (2015-04-28 01:38:13 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 02:48:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194561