Source/core/css/CSSPrimitiveValue.cpp - Issue 1102373002: Fix counters() separator serialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 1102373002: Fix counters() separator serialization (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test failure Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSPrimitiveValue.cpp

diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp

index 04bf1c4e3f499710fb75ddd5256b4c21875ac10c..2af60a8a5f8d9644070f566a028caf276d81115c 100644

--- a/Source/core/css/CSSPrimitiveValue.cpp

+++ b/Source/core/css/CSSPrimitiveValue.cpp

@@ -1013,7 +1013,7 @@ String CSSPrimitiveValue::customCSSText() const

result.append(m_value.counter->identifier());

if (!separator.isEmpty()) {

result.appendLiteral(", ");

- result.append(quoteCSSStringIfNeeded(separator));

+ result.append(serializeString(separator));

}

String listStyle = m_value.counter->listStyle();

if (!listStyle.isEmpty()) {

« no previous file with comments | « LayoutTests/fast/css/counters/counter-cssText-expected.txt ('k') | no next file » | no next file with comments »