Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1102273004: [New Multicolumn] flowThreadTranslationAtOffset() needs to be relative to the flow thread. (Closed)

Created:
5 years, 8 months ago by mstensho (USE GERRIT)
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] flowThreadTranslationAtOffset() needs to be relative to the flow thread. When we want to translate from flow thread coordinates to visual coordinates, we need to return something relative to the top/left of the flow thread, not something relative to the top/left of the content box of the multicol container. This distinction matters in RTL mode, since the flow thread is then positioned at the top/right inside the multicol container. Added LayoutTests/fast/multicol/client-rects-rtl.html , which is an adaption for RTL of client-rects.html for RTL. This didn't pass prior to this fix. Also added an assertion failure test, which is what the original bug report was about. BUG=479155 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -24 lines) Patch
A + LayoutTests/fast/multicol/client-rects-rtl.html View 2 chunks +2 lines, -1 line 0 comments Download
A + LayoutTests/fast/multicol/client-rects-rtl-expected.html View 3 chunks +20 lines, -20 lines 0 comments Download
A LayoutTests/fast/multicol/very-wide-rtl-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/very-wide-rtl-crash-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 8 months ago (2015-04-27 13:51:48 UTC) #1
dsinclair
lgtm
5 years, 8 months ago (2015-04-27 14:42:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102273004/1
5 years, 8 months ago (2015-04-27 14:42:19 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 15:05:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194517

Powered by Google App Engine
This is Rietveld 408576698