Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1102273004: [New Multicolumn] flowThreadTranslationAtOffset() needs to be relative to the flow thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1102273004: [New Multicolumn] flowThreadTranslationAtOffset() needs to be relative to the flow thread. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/very-wide-rtl-crash-expected.txt ('k') | Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/Source/core/layout/MultiColumnFragmentainerGroup.h b/Source/core/layout/MultiColumnFragmentainerGroup.h

index 13a75e409105d156f83993f3899034d456d3cb64..e6b7a3666cfeb3da0e5a409b42661484bb9ae523 100644

--- a/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -83,6 +83,7 @@ private:

LayoutUnit calculateColumnHeight(BalancedColumnHeightCalculation) const;

+ LayoutSize translationAtColumn(unsigned columnIndex) const;

LayoutRect columnRectAt(unsigned columnIndex) const;

LayoutUnit logicalTopInFlowThreadAt(unsigned columnIndex) const { return m_logicalTopInFlowThread + columnIndex * m_columnHeight; }

LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const;

« no previous file with comments | « LayoutTests/fast/multicol/very-wide-rtl-crash-expected.txt ('k') | Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »