Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1102233002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/media_galleries , metrics and nacl_host (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 7 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), asvitkine+watch_chromium.org, tzik, Lei Zhang, nhiroki, tommycli, Greg Billock, native-client-reviews_googlegroups.com, kinuko+fileapi, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/media_galleries , metrics and nacl_host modules BUG=466848 Committed: https://crrev.com/21999efe098e256c5b2099f450d155e6d48a4cd8 Cr-Commit-Position: refs/heads/master@{#327233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
anujsharma
mseaborn@chromium.org: Please review changes in chrome/browser/nacl_host estade@chromium.org: Please review changes in chrome/browser/media_galleries mpearson@chromium.org: Please review ...
5 years, 8 months ago (2015-04-27 10:17:54 UTC) #2
Mark P
lgtm I am right in assuming this is a mechanical change that has no functional ...
5 years, 8 months ago (2015-04-27 22:30:38 UTC) #3
Evan Stade
lgtm
5 years, 8 months ago (2015-04-27 22:33:32 UTC) #4
Mark Seaborn
LGTM
5 years, 8 months ago (2015-04-27 22:39:07 UTC) #5
anujsharma
On 2015/04/27 22:39:07, Mark Seaborn wrote: > LGTM Thanks Mark P, Evan and Mark Seaborn ...
5 years, 7 months ago (2015-04-28 03:16:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102233002/1
5 years, 7 months ago (2015-04-28 03:16:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 04:57:22 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 04:58:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21999efe098e256c5b2099f450d155e6d48a4cd8
Cr-Commit-Position: refs/heads/master@{#327233}

Powered by Google App Engine
This is Rietveld 408576698