chrome/browser/metrics/thread_watcher.cc - Issue 1102233002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/media_galleries , metrics and nacl_host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/thread_watcher.cc

Issue 1102233002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/media_galleries , metrics and nacl_host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/thread_watcher.cc

diff --git a/chrome/browser/metrics/thread_watcher.cc b/chrome/browser/metrics/thread_watcher.cc

index 27dc82511b812a8aba1a8eeee256932a98c611d3..ec130459b523b474b8368900e49551004f9e01a3 100644

--- a/chrome/browser/metrics/thread_watcher.cc

+++ b/chrome/browser/metrics/thread_watcher.cc

@@ -346,7 +346,7 @@ ThreadWatcherList::CrashDataThresholds::CrashDataThresholds()

// static

void ThreadWatcherList::StartWatchingAll(

const base::CommandLine& command_line) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

uint32 unresponsive_threshold;

CrashOnHangThreadMap crash_on_hang_threads;

ParseCommandLine(command_line,

« no previous file with comments | « chrome/browser/metrics/field_trial_synchronizer.cc ('k') | chrome/browser/metrics/thread_watcher_android.cc » ('j') | no next file with comments »