Issue 110223004: linux-aura: Fix some dragging behaviour.

Issue 110223004: linux-aura: Fix some dragging behaviour. (Closed)

Created:
7 years ago by sadrul

Modified:
7 years ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux-aura: Fix some dragging behaviour. Do a proper X11 grab on capture. This fixes a number of issues, including dragging a tab out of a tabstrip, and then dragging it back in. BUG=318020 R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241160

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -11 lines)			Patch
M	ui/views/views.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View	1 2	7 chunks	+10 lines, -9 lines	0 comments	Download
A	ui/views/widget/desktop_aura/x11_scoped_capture.h	View	1 2 3	1 chunk	+29 lines, -0 lines	0 comments	Download
A	ui/views/widget/desktop_aura/x11_scoped_capture.cc	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc	View		3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

lgtm https://codereview.chromium.org/110223004/diff/30001/ui/views/widget/desktop_aura/x11_scoped_capture.h File ui/views/widget/desktop_aura/x11_scoped_capture.h (right): https://codereview.chromium.org/110223004/diff/30001/ui/views/widget/desktop_aura/x11_scoped_capture.h#newcode14 ui/views/widget/desktop_aura/x11_scoped_capture.h:14: class X11ScopedCapture { nit: document class

7 years ago (2013-12-16 18:29:17 UTC) #2

sadrul

https://codereview.chromium.org/110223004/diff/30001/ui/views/widget/desktop_aura/x11_scoped_capture.h File ui/views/widget/desktop_aura/x11_scoped_capture.h (right): https://codereview.chromium.org/110223004/diff/30001/ui/views/widget/desktop_aura/x11_scoped_capture.h#newcode14 ui/views/widget/desktop_aura/x11_scoped_capture.h:14: class X11ScopedCapture { On 2013/12/16 18:29:18, Elliot Glaysher wrote: ...

7 years ago (2013-12-17 04:34:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r241160 (presubmit successful).

Expand Messages | Collapse Messages