Issue 11021008: Added 'dynamic' keyword, so that 'Dynamic' can be deprecated.

Issue 11021008: Added 'dynamic' keyword, so that 'Dynamic' can be deprecated. (Closed)

Created:
8 years, 2 months ago by aam-me

Modified:
8 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added 'dynamic' keyword, so that 'Dynamic' can be deprecated. BUG=dartbug.com/5118 TEST= Committed: https://code.google.com/p/dart/source/detail?r=13510

Patch Set 2 : Updated tests status file with entered co19 issue. #

Total comments: 2

Patch Set 3 : Updated dart2dart test status file with co19 issue as well. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/keyword.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/parser.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/scanner.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/unparser2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/apply2_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11021008/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/11021008/diff/1/tests/co19/co19-dart2js.status#newcode325 tests/co19/co19-dart2js.status:325: Language/10_Expressions/28_Identifier_Reference_A06_t13: Fail, OK # co19 issue: test expects ...

8 years, 2 months ago (2012-10-10 08:48:15 UTC) #2

aam-me

Thanks, Peter, for the review. I entered co19 bug. Please, take another look when you ...

8 years, 2 months ago (2012-10-10 12:37:39 UTC) #3

ahe

LGTM! https://chromiumcodereview.appspot.com/11021008/diff/8001/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://chromiumcodereview.appspot.com/11021008/diff/8001/tests/co19/co19-dart2dart.status#newcode412 tests/co19/co19-dart2dart.status:412: Language/10_Expressions/28_Identifier_Reference_A06_t13: Fail, OK # co19 issue: test expects ...

8 years, 2 months ago (2012-10-10 13:02:57 UTC) #4

aam-me

8 years, 2 months ago (2012-10-10 17:08:24 UTC) #5

Thanks for pointing that out, Peter!

https://chromiumcodereview.appspot.com/11021008/diff/8001/tests/co19/co19-dar...
File tests/co19/co19-dart2dart.status (right):

https://chromiumcodereview.appspot.com/11021008/diff/8001/tests/co19/co19-dar...
tests/co19/co19-dart2dart.status:412:
Language/10_Expressions/28_Identifier_Reference_A06_t13: Fail, OK # co19 issue:
test expects compile-time error, but '@' is missing in front of 'compile-error'.
On 2012/10/10 13:02:57, ahe wrote:
> Use bug number here as well?

Done.

Expand Messages | Collapse Messages