Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1102083002: Do not crash nanobench in debug mode (Closed)

Created:
5 years, 8 months ago by msarett
Modified:
5 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not crash nanobench in debug mode Instead print an error message BUG=skia: Committed: https://skia.googlesource.com/skia/+/9d9725c892743cf8fc66ea6cdd5ce21fe2df6d14

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
msarett
5 years, 8 months ago (2015-04-24 18:24:29 UTC) #2
scroggo
lgtm https://codereview.chromium.org/1102083002/diff/20001/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/1102083002/diff/20001/bench/nanobench.cpp#newcode644 bench/nanobench.cpp:644: SkDebugf("Cannot find codec for %s\n", path.c_str()); I thought ...
5 years, 8 months ago (2015-04-24 18:27:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102083002/20001
5 years, 8 months ago (2015-04-24 18:28:50 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:42:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/9d9725c892743cf8fc66ea6cdd5ce21fe2df6d14

Powered by Google App Engine
This is Rietveld 408576698