Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: bench/nanobench.cpp

Issue 1102083002: Do not crash nanobench in debug mode (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/nanobench.cpp
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index bf99a1eee14db425a5375e07e18ce538ed58314b..0045d53f40ea6ad41b8d8ccf163b3a20492409ea 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -639,9 +639,9 @@ public:
const SkString& path = fImages[fCurrentCodec];
SkAutoTUnref<SkData> encoded(SkData::NewFromFileName(path.c_str()));
SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(encoded));
- SkASSERT(codec);
if (!codec) {
// Nothing to time.
+ SkDebugf("Cannot find codec for %s\n", path.c_str());
scroggo 2015/04/24 18:27:24 I thought you said it printed this without adding
continue;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698