Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: src/full-codegen.h

Issue 110203002: Refactor the compiling pipeline. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: move some code Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen.h
diff --git a/src/full-codegen.h b/src/full-codegen.h
index 11d5341ecab48ee877a05f3ceb7b5d56a80cc287..35b864432758b03470c1f934fd96eadbecbf218c 100644
--- a/src/full-codegen.h
+++ b/src/full-codegen.h
@@ -928,9 +928,9 @@ class BackEdgeTable {
// Change a back edge patched for on-stack replacement to perform a
// stack check first.
- static void AddStackCheck(CompilationInfo* info);
+ static void AddStackCheck(Code* code, uint32_t pc_offset);
titzer 2013/12/09 14:49:28 Why not a Handle<Code>?
- // Remove the stack check, if available, and replace by on-stack replacement.
+ // Revert the patch by AddStackCheck.
static void RemoveStackCheck(CompilationInfo* info);
titzer 2013/12/09 14:49:28 And why does this one take a CompilationInfo? Does
Yang 2013/12/10 11:22:04 This removes only the one added in AddStackCheck.
titzer 2013/12/17 15:27:55 I think Add and Remove should be symmetric, and ne
Yang 2013/12/17 16:31:33 Made the signatures symmetrical.
// Return the current patch state of the back edge.

Powered by Google App Engine
This is Rietveld 408576698