Refactor the compiling pipeline.

src/full-codegen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 910 matching lines @@
                       Address pc,
                       BackEdgeState target_state,
                       Code* replacement_code);
 
   // Change all patched back edges back to normal interrupts.
   static void Revert(Isolate* isolate,
                      Code* unoptimized_code);
 
   // Change a back edge patched for on-stack replacement to perform a
   // stack check first.
-  static void AddStackCheck(CompilationInfo* info);
+  static void AddStackCheck(Code* code, uint32_t pc_offset);

[titzer, 2013/12/09 14:49:28]

Why not a Handle<Code>?

 
-  // Remove the stack check, if available, and replace by on-stack replacement.
+  // Revert the patch by AddStackCheck.
   static void RemoveStackCheck(CompilationInfo* info);

[titzer, 2013/12/09 14:49:28]

And why does this one take a CompilationInfo? Does it remove all checks, or just
one?

[Yang, 2013/12/10 11:22:04]

This removes only the one added in AddStackCheck. All the necessary information
are in the compilation info, so I though passing that would be cleaner.

[titzer, 2013/12/17 15:27:55]

I think Add and Remove should be symmetric, and neither should take a
CompilationInfo, which is an indirection to the stuff needed for the operation.

[Yang, 2013/12/17 16:31:33]

Made the signatures symmetrical.

 
   // Return the current patch state of the back edge.
   static BackEdgeState GetBackEdgeState(Isolate* isolate,
                                         Code* unoptimized_code,
                                         Address pc_after);
 
 #ifdef DEBUG
   // Verify that all back edges of a certain loop depth are patched.
   static bool Verify(Isolate* isolate,
                      Code* unoptimized_code,
@@ skipping 14 matching lines @@
 
   Address start_;
   Address instruction_start_;
   uint32_t length_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_FULL_CODEGEN_H_