Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 110173005: Don't dispatch a 'click' event for mousedown/mouseup across form controls. (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Don't dispatch a 'click' event for mousedown/mouseup across form controls. This CL fixes a regression by r162081 [1]. The behavior change by r162081 was correct according to the standard, however it caused unexpected behavior on some sites. IE11 doesn't dispatch a click event if a mousedown event happened on a form control, and a mouseup event happened on anoter element. We follow it. [1] http://src.chromium.org/viewvc/blink?revision=162081&view=revision BUG=328304, 329136 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164073

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Patch Set 3 : fix a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M LayoutTests/fast/dom/shadow/select-in-shadowdom.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/click-over-descendant-elements.html View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/click-over-descendant-elements-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
tasak@, hayato@, would you review this please?
5 years, 6 months ago (2013-12-18 03:20:50 UTC) #1
hayato
LGTM. https://codereview.chromium.org/110173005/diff/1/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/110173005/diff/1/Source/core/page/EventHandler.cpp#newcode1617 Source/core/page/EventHandler.cpp:1617: // IE doesn't dispatch click events for mousedown/mouseup ...
5 years, 6 months ago (2013-12-18 03:46:17 UTC) #2
tkent
https://codereview.chromium.org/110173005/diff/1/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/110173005/diff/1/Source/core/page/EventHandler.cpp#newcode1617 Source/core/page/EventHandler.cpp:1617: // IE doesn't dispatch click events for mousedown/mouseup events ...
5 years, 6 months ago (2013-12-18 03:52:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/110173005/40001
5 years, 6 months ago (2013-12-18 05:19:48 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2013-12-18 07:35:12 UTC) #5
Message was sent while issue was closed.
Change committed as 164073

Powered by Google App Engine
This is Rietveld 408576698