Source/core/dom/Node.h - Issue 110173005: Don't dispatch a 'click' event for mousedown/mouseup across form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.h

Issue 110173005: Don't dispatch a 'click' event for mousedown/mouseup across form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix a test Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.h

diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h

index e17c0b1c0335f1a1688ef65ec5aba73c7610b0e3..36235187f71f65bc7c1a2bed859e7b98bc21723d 100644

--- a/Source/core/dom/Node.h

+++ b/Source/core/dom/Node.h

@@ -499,7 +499,7 @@ public:

bool contains(const Node*) const;

bool containsIncludingShadowDOM(const Node*) const;

bool containsIncludingHostElements(const Node&) const;

- Node* commonAncestorOverShadowBoundary(const Node&);

+ Node* commonAncestor(const Node&, Node* (*parent)(const Node&));

// FIXME: Remove this when crbug.com/265716 cleans up contains semantics.

bool bindingsContains(const Node* node) const { return containsIncludingShadowDOM(node); }