Issue 1101663007: Make non-AA hairline stroke rects snap to pixels centers so they close.

Issue 1101663007: Make non-AA hairline stroke rects snap to pixels centers so they close. (Closed)

Created:
5 years, 8 months ago by bsalomon

Modified:
5 years, 7 months ago

Reviewers:
joshualitt, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Make non-AA hairline stroke rects snap to pixels centers so they close. BUG=skia:3717 Committed: https://skia.googlesource.com/skia/+/d79c549467e5e7be025e38357f179b7965ed2ec3

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -34 lines)			Patch
M	src/gpu/GrClipMaskManager.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/gpu/GrPipeline.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrPipeline.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/gpu/GrPipelineBuilder.h	View	2 chunks	+24 lines, -17 lines	0 comments	Download
M	src/gpu/GrPipelineBuilder.cpp	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/GrProgramDesc.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp	View	2 chunks	+14 lines, -8 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101663007/1

5 years, 7 months ago (2015-04-27 16:28:57 UTC) #5

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 7 months ago (2015-04-27 16:36:46 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101663007/1

5 years, 7 months ago (2015-04-27 17:06:54 UTC) #9

commit-bot: I haz the power

5 years, 7 months ago (2015-04-27 17:07:08 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d79c549467e5e7be025e38357f179b7965ed2ec3