Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 110163004: Remove Chrome Frame ready-mode. (Closed)

Created:
7 years ago by grt (UTC plus 2)
Modified:
7 years ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix unittest compile failure #

Patch Set 3 : remove ready_mode_unittest.cc #

Patch Set 4 : compile fixes for mini_installer_test #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2283 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/setup/chrome_frame_quick_enable.cc View 3 chunks +2 lines, -6 lines 0 comments Download
D chrome/installer/setup/chrome_frame_ready_mode.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/installer/setup/chrome_frame_ready_mode.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M chrome/installer/setup/install_worker.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 3 chunks +0 lines, -153 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 1 20 chunks +22 lines, -87 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 5 chunks +2 lines, -59 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 chunk +2 lines, -23 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 3 chunks +2 lines, -20 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.cc View 8 chunks +3 lines, -27 lines 0 comments Download
M chrome/installer/util/installation_validator.h View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/installer/util/installation_validator.cc View 7 chunks +4 lines, -40 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 9 chunks +9 lines, -29 lines 3 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/util_constants.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/mini_installer_test/switch_builder.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/mini_installer_test/switch_builder.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/mini_installer_test/test.cc View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
D chrome_frame/ready_mode/internal/ready_mode_state.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome_frame/ready_mode/internal/ready_prompt_content.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome_frame/ready_mode/internal/ready_prompt_content.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome_frame/ready_mode/internal/ready_prompt_window.h View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome_frame/ready_mode/internal/ready_prompt_window.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome_frame/ready_mode/internal/registry_ready_mode_state.h View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome_frame/ready_mode/internal/registry_ready_mode_state.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D chrome_frame/ready_mode/ready_mode.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome_frame/ready_mode/ready_mode.cc View 1 chunk +0 lines, -400 lines 0 comments Download
D chrome_frame/test/ready_mode_unittest.cc View 1 2 1 chunk +0 lines, -286 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
grt (UTC plus 2)
7 years ago (2013-12-11 19:56:31 UTC) #1
robertshield
lgtm https://codereview.chromium.org/110163004/diff/20002/chrome/installer/util/installation_validator_unittest.cc File chrome/installer/util/installation_validator_unittest.cc (right): https://codereview.chromium.org/110163004/diff/20002/chrome/installer/util/installation_validator_unittest.cc#newcode57 chrome/installer/util/installation_validator_unittest.cc:57: CM_FULL = 0x08 is it necessary / a ...
7 years ago (2013-12-11 20:56:48 UTC) #2
grt (UTC plus 2)
Thanks! https://codereview.chromium.org/110163004/diff/20002/chrome/installer/util/installation_validator_unittest.cc File chrome/installer/util/installation_validator_unittest.cc (right): https://codereview.chromium.org/110163004/diff/20002/chrome/installer/util/installation_validator_unittest.cc#newcode57 chrome/installer/util/installation_validator_unittest.cc:57: CM_FULL = 0x08 On 2013/12/11 20:56:49, robertshield wrote: ...
7 years ago (2013-12-11 22:13:55 UTC) #3
robertshield
https://codereview.chromium.org/110163004/diff/20002/chrome/installer/util/installation_validator_unittest.cc File chrome/installer/util/installation_validator_unittest.cc (right): https://codereview.chromium.org/110163004/diff/20002/chrome/installer/util/installation_validator_unittest.cc#newcode57 chrome/installer/util/installation_validator_unittest.cc:57: CM_FULL = 0x08 On 2013/12/11 22:13:55, grt wrote: > ...
7 years ago (2013-12-11 22:19:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/110163004/20002
7 years ago (2013-12-12 02:29:17 UTC) #5
grt (UTC plus 2)
TBR=jcivelli@chromium.org for chrome/test/mini_installer_test changes.
7 years ago (2013-12-12 02:43:46 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-12 14:12:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/110163004/20002
7 years ago (2013-12-12 14:28:09 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-12 18:22:41 UTC) #9
Message was sent while issue was closed. 
Change committed as 240363

Powered by Google App Engine
This is Rietveld 408576698