Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3523)

Unified Diff: chrome/installer/setup/setup_util.cc

Issue 110163004: Remove Chrome Frame ready-mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fixes for mini_installer_test Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/setup_util.cc
diff --git a/chrome/installer/setup/setup_util.cc b/chrome/installer/setup/setup_util.cc
index da46e4f4889e4b2e34060ec9b25c8cc4583b327b..b7422a2ec784a6bea1ac6487f061c2b6b5325be9 100644
--- a/chrome/installer/setup/setup_util.cc
+++ b/chrome/installer/setup/setup_util.cc
@@ -323,33 +323,12 @@ bool WillProductBePresentAfterSetup(
machine_state.GetProductState(installer_state.system_install(), type);
// Determine if the product is present prior to the current operation.
- bool is_present = false;
- if (product_state != NULL) {
- if (type == BrowserDistribution::CHROME_FRAME) {
- is_present = !product_state->uninstall_command().HasSwitch(
- switches::kChromeFrameReadyMode);
- } else {
- is_present = true;
- }
- }
-
+ bool is_present = (product_state != NULL);
bool is_uninstall = installer_state.operation() == InstallerState::UNINSTALL;
// Determine if current operation affects the product.
- bool is_affected = false;
const Product* product = installer_state.FindProduct(type);
- if (product != NULL) {
- if (type == BrowserDistribution::CHROME_FRAME) {
- // If Chrome Frame is being uninstalled, we don't bother to check
- // !HasOption(kOptionReadyMode) since CF would not have been installed
- // in the first place. If for some odd reason it weren't, we would be
- // conservative, and cause false to be retruned since CF should not be
- // installed then (so is_uninstall = true and is_affected = true).
- is_affected = is_uninstall || !product->HasOption(kOptionReadyMode);
- } else {
- is_affected = true;
- }
- }
+ bool is_affected = (product != NULL);
// Decide among {(1),(2),(3),(4)}.
return is_affected ? !is_uninstall : is_present;

Powered by Google App Engine
This is Rietveld 408576698