Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 11016023: Quickly close tabs/window with long-running unload handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep original TabsNeedBeforeUnloadFired implementation. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 1c23b924624f7cebdadc2ff5225adb048fd0b2a6..6a70f6559f62c1213ac5d2b5be4071b455e9699d 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -248,6 +248,9 @@ class CONTENT_EXPORT WebContentsImpl
virtual base::TimeTicks GetNewTabStartTime() const OVERRIDE;
virtual void Close() OVERRIDE;
virtual void OnCloseStarted() OVERRIDE;
+ virtual void OnCloseCanceled() OVERRIDE;
+ virtual void OnUnloadStarted() OVERRIDE;
+ virtual void OnUnloadDetachedStarted() OVERRIDE;
virtual bool ShouldAcceptDragAndDrop() const OVERRIDE;
virtual void SystemDragEnded() OVERRIDE;
virtual void UserGestureDone() OVERRIDE;
@@ -811,6 +814,9 @@ class CONTENT_EXPORT WebContentsImpl
// The time when onbeforeunload ended.
base::TimeTicks before_unload_end_time_;
+ // The time when the tab was removed from view during close.
+ base::TimeTicks unload_detached_start_time_;
+
// The time that this tab was last selected.
base::TimeTicks last_selected_time_;

Powered by Google App Engine
This is Rietveld 408576698