Quickly close tabs/window with long-running unload handlers.

chrome/browser/ui/tabs/tab_strip_model.h

Index: chrome/browser/ui/tabs/tab_strip_model.h
diff --git a/chrome/browser/ui/tabs/tab_strip_model.h b/chrome/browser/ui/tabs/tab_strip_model.h
index f988e7a611e6407682808cc5db1b35dcecd2bf87..8c16ee954a31d512c13fbda69b7d4bddf73feb3f 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.h
+++ b/chrome/browser/ui/tabs/tab_strip_model.h
@@ -227,6 +227,12 @@ class TabStripModel : public content::NotificationObserver {
   // strip).
   TabContents* DetachTabContentsAt(int index);
 
+  // Detached the TabContents like DetachTabContentsAt, however,
+  // CreateHistoricalTab is invoked on the delegate. The caller can use
+  // this to hide the tab while unload handlers run. The caller is responsible
+  // for destroying the tab.
+  TabContents* DetachTabContentsAndCreateHistoryAt(int index);

[Avi (use Gerrit), 2012/11/15 18:56:43]

I don't see the point in having this. It's a two liner for behavior that the
caller can do themselves.

TabContents* contents = tab_strip->DetachTabContentsAt(i);
tab_strip->delegate()->CreateHistoricalTab(contents->web_contents());

And if this is not desired (and please say why not), then add a DetachTypes
parameter to DetachTabContents, not a new function.

[slamm_google, 2012/11/15 22:20:36]

It felt wrong to me too. Thank you for the alternative. That is much better.
Done. 
That is a good design preference to know.

+
   // Makes the tab at the specified index the active tab. |user_gesture| is true
   // if the user actually clicked on the tab or navigated to it using a keyboard
   // command, false if the tab was activated as a by-product of some other