Quickly close tabs/window with long-running unload handlers.

chrome/browser/ui/tabs/tab_strip_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TABS_TAB_STRIP_MODEL_H_
 #define CHROME_BROWSER_UI_TABS_TAB_STRIP_MODEL_H_
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 209 matching lines @@
   // especially on Chrome OS. The tab reloads if the user clicks on it.
   // Returns an empty TabContents, used only for testing.
   TabContents* DiscardTabContentsAt(int index);
 
   // Detaches the TabContents at the specified index from this strip. The
   // TabContents is not destroyed, just removed from display. The caller
   // is responsible for doing something with it (e.g. stuffing it into another
   // strip).
   TabContents* DetachTabContentsAt(int index);
 
+  // Detached the TabContents like DetachTabContentsAt, however,
+  // CreateHistoricalTab is invoked on the delegate. The caller can use
+  // this to hide the tab while unload handlers run. The caller is responsible
+  // for destroying the tab.
+  TabContents* DetachTabContentsAndCreateHistoryAt(int index);

[Avi (use Gerrit), 2012/11/15 18:56:43]

I don't see the point in having this. It's a two liner for behavior that the
caller can do themselves.

TabContents* contents = tab_strip->DetachTabContentsAt(i);
tab_strip->delegate()->CreateHistoricalTab(contents->web_contents());

And if this is not desired (and please say why not), then add a DetachTypes
parameter to DetachTabContents, not a new function.

[slamm_google, 2012/11/15 22:20:36]

It felt wrong to me too. Thank you for the alternative. That is much better.
Done. 
That is a good design preference to know.

+
   // Makes the tab at the specified index the active tab. |user_gesture| is true
   // if the user actually clicked on the tab or navigated to it using a keyboard
   // command, false if the tab was activated as a by-product of some other
   // action.
   void ActivateTabAt(int index, bool user_gesture);
 
   // Adds tab at |index| to the currently selected tabs, without changing the
   // active tab index.
   void AddTabAtToSelection(int index);
 
@@ skipping 433 matching lines @@
 
   // A scoped container for notification registries.
   content::NotificationRegistrar registrar_;
 
   TabStripSelectionModel selection_model_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(TabStripModel);
 };
 
 #endif  // CHROME_BROWSER_UI_TABS_TAB_STRIP_MODEL_H_