Issue 1101593003: [chrome/browser/ui] favor DCHECK_CURRENTLY_ON for better logs

Issue 1101593003: [chrome/browser/ui] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/ui BUG=466848 Committed: https://crrev.com/35d72eaa376afeefee1ee27b6320b56df5b60117 Cr-Commit-Position: refs/heads/master@{#326733}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	chrome/browser/ui/sync/profile_signin_confirmation_helper.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/session_crashed_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/image_source.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/l10n_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/23 15:41:16, sky wrote: > LGTM Thanks sky for lgtm

5 years, 8 months ago (2015-04-24 02:15:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101593003/20001

5 years, 8 months ago (2015-04-24 02:16:43 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 03:17:05 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/35d72eaa376afeefee1ee27b6320b56df5b60117
Cr-Commit-Position: refs/heads/master@{#326733}