Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4357)

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

Issue 1101593003: [chrome/browser/ui] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed build break Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
index 1277b64d2daedb7f41694adf158efb7ed16283e8..8df2618155afe75b6ac02e1038dd5dd8a1902b8d 100644
--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
@@ -113,7 +113,7 @@ ProfileSigninConfirmationHelper::ProfileSigninConfirmationHelper(
}
ProfileSigninConfirmationHelper::~ProfileSigninConfirmationHelper() {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
}
void ProfileSigninConfirmationHelper::OnHistoryQueryResults(
@@ -164,7 +164,7 @@ void ProfileSigninConfirmationHelper::CheckHasTypedURLs() {
}
void ProfileSigninConfirmationHelper::ReturnResult(bool result) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// Pass |true| into the callback as soon as one of the tasks passes a
// result of |true|, otherwise pass the last returned result.
if (--pending_requests_ == 0 || result) {
@@ -229,7 +229,7 @@ bool HasSyncedExtensions(Profile* profile) {
void CheckShouldPromptForNewProfile(
Profile* profile,
const base::Callback<void(bool)>& return_result) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (HasBeenShutdown(profile) ||
HasBookmarks(profile) ||
« no previous file with comments | « no previous file | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698