Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: Source/bindings/scripts/generate_global_constructors.py

Issue 1101583003: compositor-worker: Restrict the global interface in CompositorWorker. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/generate_global_constructors.py
diff --git a/Source/bindings/scripts/generate_global_constructors.py b/Source/bindings/scripts/generate_global_constructors.py
index 7a27703b7c9874273206265257ca353de17c6d45..2fe860d0e33cc73831dd801963097c17c1d5abf9 100755
--- a/Source/bindings/scripts/generate_global_constructors.py
+++ b/Source/bindings/scripts/generate_global_constructors.py
@@ -36,6 +36,10 @@ HEADER_FORMAT = """// Stub header file for {{idl_basename}}
// exists for each IDL file.
"""
+EXTRA_GLOBAL_NAME_FROM_MODULES = frozenset([
+ 'CompositorWorker',
haraken 2015/04/22 11:07:28 Can we avoid adding this here by tweaking Exposure
sadrul 2015/04/22 22:17:19 The error I get without the change in this file is
+])
+
def parse_options():
parser = optparse.OptionParser()
parser.add_option('--idl-files-list', help='file listing IDL files')
@@ -166,7 +170,8 @@ def main():
record_global_constructors(idl_filename)
# Check for [Exposed] / [Global] mismatch.
- known_global_names = frozenset(itertools.chain.from_iterable(interface_name_to_global_names.values()))
+ known_global_names = set(itertools.chain.from_iterable(interface_name_to_global_names.values()))
+ known_global_names.update(EXTRA_GLOBAL_NAME_FROM_MODULES)
exposed_global_names = frozenset(global_name_to_constructors)
if not exposed_global_names.issubset(known_global_names):
unknown_global_names = exposed_global_names.difference(known_global_names)

Powered by Google App Engine
This is Rietveld 408576698