compositor-worker: Restrict the global interface in CompositorWorker.

Source/bindings/scripts/generate_global_constructors.py

 #!/usr/bin/python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates interface properties on global objects.
 
 Concretely these are implemented as "constructor attributes", meaning
 "attributes whose name ends with Constructor" (special-cased by code generator),
@@ skipping 18 matching lines @@
 
 interface_name_to_global_names = {}
 global_name_to_constructors = defaultdict(list)
 
 
 HEADER_FORMAT = """// Stub header file for {{idl_basename}}
 // Required because the IDL compiler assumes that a corresponding header file
 // exists for each IDL file.
 """
 
+EXTRA_GLOBAL_NAME_FROM_MODULES = frozenset([
+    'CompositorWorker',

[haraken, 2015/04/22 11:07:28]

Can we avoid adding this here by tweaking ExposureSet in v8_utilities.py?

[sadrul, 2015/04/22 22:17:19]

The error I get without the change in this file is from the check below in line
176, with the following backtrace:

Traceback (most recent call last):
  File "../scripts/generate_global_constructors.py", line 195, in <module>
    sys.exit(main())
  File "../scripts/generate_global_constructors.py", line 181, in main
    % list(unknown_global_names))
ValueError: The following global names were used in [Exposed=xxx] but do not
match any [Global] / [PrimaryGlobal] interface: ['CompositorWorker']


I looked at v8_utilities, but it doesn't look like any of the v8_* files get
used from this file, and I couldn't figure out a way of using ExposureSet from
here. Perhaps you could direct me towards some code that I should look at?

+])
+
 def parse_options():
     parser = optparse.OptionParser()
     parser.add_option('--idl-files-list', help='file listing IDL files')
     parser.add_option('--global-objects-file', help='pickle file of global objects')
     parser.add_option('--write-file-only-if-changed', type='int', help='if true, do not write an output file if it would be identical to the existing one, which avoids unnecessary rebuilds in ninja')
 
     options, args = parser.parse_args()
 
     if options.idl_files_list is None:
         parser.error('Must specify a file listing IDL files using --idl-files-list.')
@@ skipping 110 matching lines @@
     interface_name_idl_filename = [(args[i], args[i + 1])
                                    for i in range(0, len(args), 2)]
 
     with open(options.global_objects_file) as global_objects_file:
         interface_name_to_global_names.update(pickle.load(global_objects_file))
 
     for idl_filename in idl_files:
         record_global_constructors(idl_filename)
 
     # Check for [Exposed] / [Global] mismatch.
-    known_global_names = frozenset(itertools.chain.from_iterable(interface_name_to_global_names.values()))
+    known_global_names = set(itertools.chain.from_iterable(interface_name_to_global_names.values()))
+    known_global_names.update(EXTRA_GLOBAL_NAME_FROM_MODULES)
     exposed_global_names = frozenset(global_name_to_constructors)
     if not exposed_global_names.issubset(known_global_names):
         unknown_global_names = exposed_global_names.difference(known_global_names)
         raise ValueError('The following global names were used in '
                          '[Exposed=xxx] but do not match any [Global] / '
                          '[PrimaryGlobal] interface: %s'
                          % list(unknown_global_names))
 
     # Write partial interfaces containing constructor attributes for each
     # global interface.
     for interface_name, idl_filename in interface_name_idl_filename:
         constructors = interface_name_to_constructors(interface_name)
         write_global_constructors_partial_interface(
             interface_name,
             idl_filename,
             constructors,
             options.write_file_only_if_changed)
 
 
 if __name__ == '__main__':
     sys.exit(main())