Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 11013023: Android backend: add CONFIGURATION_NAME. (Closed)

Created:
8 years, 2 months ago by Torne
Modified:
8 years, 2 months ago
Reviewers:
bradnelson, bradn
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Android backend: add CONFIGURATION_NAME. The recently added CONFIGURATION_NAME variable needs to be defined by the generator in order to be able to parse various gyp files in the Chromium tree, even though none of the targets build using the Android backend actually use it. The Android backend doesn't have a concept of separate configurations, so define it to a value that will cause an obvious error if a target uses it inappropriately. Committed: https://code.google.com/p/gyp/source/detail?r=1514

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pylib/gyp/generator/android.py View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Torne
Brad, can you take a look at this?
8 years, 2 months ago (2012-10-03 11:48:40 UTC) #1
bradn
LGTM https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py#newcode41 pylib/gyp/generator/android.py:41: 'CONFIGURATION_NAME': 'NOT_USED_ON_ANDROID', Is this actually getting referenced and ...
8 years, 2 months ago (2012-10-03 17:21:42 UTC) #2
Torne
https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py#newcode41 pylib/gyp/generator/android.py:41: 'CONFIGURATION_NAME': 'NOT_USED_ON_ANDROID', On 2012/10/03 17:21:42, bradn wrote: > Is ...
8 years, 2 months ago (2012-10-04 10:54:58 UTC) #3
bradn
8 years, 2 months ago (2012-10-04 16:19:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698