Chromium Code Reviews
Help | Chromium Project | Sign in
(474)

Issue 11013023: Android backend: add CONFIGURATION_NAME. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Torne
Modified:
1 year, 6 months ago
Reviewers:
bradnelson, bradn
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Android backend: add CONFIGURATION_NAME.

The recently added CONFIGURATION_NAME variable needs to be defined by the
generator in order to be able to parse various gyp files in the Chromium tree,
even though none of the targets build using the Android backend actually use
it. The Android backend doesn't have a concept of separate configurations, so
define it to a value that will cause an obvious error if a target uses it
inappropriately.
Committed: https://code.google.com/p/gyp/source/detail?r=1514

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Lint Patch
M pylib/gyp/generator/android.py View 1 chunk +1 line, -0 lines 2 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Torne
Brad, can you take a look at this?
1 year, 6 months ago #1
bradn
LGTM https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py#newcode41 pylib/gyp/generator/android.py:41: 'CONFIGURATION_NAME': 'NOT_USED_ON_ANDROID', Is this actually getting referenced and ...
1 year, 6 months ago #2
Torne
https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py#newcode41 pylib/gyp/generator/android.py:41: 'CONFIGURATION_NAME': 'NOT_USED_ON_ANDROID', On 2012/10/03 17:21:42, bradn wrote: > Is ...
1 year, 6 months ago #3
bradn
1 year, 6 months ago #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6