Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 11013023: Android backend: add CONFIGURATION_NAME. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
4 years, 9 months ago by Torne (Vacation until Jul 9)
4 years, 8 months ago
bradnelson, bradn


Android backend: add CONFIGURATION_NAME. The recently added CONFIGURATION_NAME variable needs to be defined by the generator in order to be able to parse various gyp files in the Chromium tree, even though none of the targets build using the Android backend actually use it. The Android backend doesn't have a concept of separate configurations, so define it to a value that will cause an obvious error if a target uses it inappropriately. Committed:

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pylib/gyp/generator/ View 1 chunk +1 line, -0 lines 2 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 4 (0 generated)
Torne (Vacation until Jul 9)
Brad, can you take a look at this?
4 years, 9 months ago (2012-10-03 11:48:40 UTC) #1
LGTM File pylib/gyp/generator/ (right): pylib/gyp/generator/ 'CONFIGURATION_NAME': 'NOT_USED_ON_ANDROID', Is this actually getting referenced and ...
4 years, 8 months ago (2012-10-03 17:21:42 UTC) #2
Torne (Vacation until Jul 9) File pylib/gyp/generator/ (right): pylib/gyp/generator/ 'CONFIGURATION_NAME': 'NOT_USED_ON_ANDROID', On 2012/10/03 17:21:42, bradn wrote: > Is ...
4 years, 8 months ago (2012-10-04 10:54:58 UTC) #3
4 years, 8 months ago (2012-10-04 16:19:29 UTC) #4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589