Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1101033003: Move IsOriginSecure() into //content and use it in ServiceWorker (Closed)

Created:
5 years, 8 months ago by kinuko
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, davidben, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, markusheintz_, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move IsOriginSecure() into //content and use it in ServiceWorker IsOriginSecure() implements web platform feature [1] and it'd be more natural to provide this at content-layer. Also ServiceWorker actually wants to call this in content layer for browser-side security check. https://www.w3.org/TR/powerful-features/#is-origin-trustworthy. This CL moves IsOriginSecure() from chrome/common/origin_util.{h,cc} to content/{public/,}/common/origin_util.{h,cc} and adds a following method to ContentClient so that ChromeContentClient can add chrome-level schemes (and whitelisted origins, this is to be implemented in crbug.com/441605). // Gives the embedder a chance to register additional schemes and origins // that need to be considered trustworthy. // See https://www.w3.org/TR/powerful-features/#is-origin-trustworthy. virtual void AddSecureSchemesAndOrigins(std::set<std::string>* schemes, std::set<GURL>* origins) {} BUG=362214, 441605 TEST=content_unittests:URLSchemesTest.IsOriginSecure Committed: https://crrev.com/8cbea05bcd64f3a778d92435b6102e82c2cb435b Cr-Commit-Position: refs/heads/master@{#326971}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : added disallow copy/assign #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -127 lines) Patch
M chrome/browser/content_settings/permission_context_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/origin_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/common/origin_util.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/common/origin_util_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 2 chunks +2 lines, -5 lines 0 comments Download
A content/common/origin_util.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A + content/common/origin_util_unittest.cc View 2 chunks +17 lines, -17 lines 0 comments Download
M content/content_common.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + content/public/common/origin_util.h View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
lgarron
On 2015/04/23 at 01:46:12, kinuko wrote: > kinuko@chromium.org changed reviewers: > + jochen@chromium.org, palmer@chromium.org I ...
5 years, 8 months ago (2015-04-23 01:53:09 UTC) #4
kinuko
5 years, 8 months ago (2015-04-23 02:00:49 UTC) #6
kinuko
On 2015/04/23 01:53:09, lgarron wrote: > On 2015/04/23 at 01:46:12, kinuko wrote: > > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=kinuko@chromium.org ...
5 years, 8 months ago (2015-04-23 02:07:52 UTC) #7
kinuko
palmer@, jochen@ could you review? (This CL's the one that is split from https://crrev.com/1072933006/)
5 years, 8 months ago (2015-04-23 02:10:25 UTC) #8
palmer
LGTM and is a nice improvement. Thank you!
5 years, 8 months ago (2015-04-23 18:34:13 UTC) #9
palmer
> I know this is probably not the right place to ask, but what's the ...
5 years, 8 months ago (2015-04-23 18:45:26 UTC) #10
Evan Stade
5 years, 8 months ago (2015-04-24 02:25:53 UTC) #12
Evan Stade
On 2015/04/24 02:25:53, Evan Stade wrote: disregard empty message
5 years, 8 months ago (2015-04-24 02:26:18 UTC) #13
kinuko
Thanks! jochen@: could you do owner's review?
5 years, 8 months ago (2015-04-24 03:34:13 UTC) #14
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1101033003/diff/80001/content/common/origin_util.cc File content/common/origin_util.cc (right): https://codereview.chromium.org/1101033003/diff/80001/content/common/origin_util.cc#newcode32 content/common/origin_util.cc:32: }; disallow copy/assign
5 years, 8 months ago (2015-04-24 14:03:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101033003/100001
5 years, 8 months ago (2015-04-25 11:15:11 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 8 months ago (2015-04-25 13:35:51 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 13:36:36 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8cbea05bcd64f3a778d92435b6102e82c2cb435b
Cr-Commit-Position: refs/heads/master@{#326971}

Powered by Google App Engine
This is Rietveld 408576698