Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1100823002: [New Multicolumn] Disallow spanners inside floats and absolutely positioned boxes. (Closed)

Created:
5 years, 8 months ago by mstensho (USE GERRIT)
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Disallow spanners inside floats and absolutely positioned boxes. Since the logical top of a float or absolutely positioned box isn't (guaranteed to be) known until after layout, we get problems determining the logical height of the flow thread portion preceding the spanner, which in turn means that we'll get column balancing wrong. The usefulness of spanners inside floats or absolutely positioned boxes is questionable, so just disallow spanners inside such boxes for now. BUG=479085 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A LayoutTests/fast/multicol/span/inside-abspos-crash.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/fast/multicol/span/inside-abspos-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/inside-float-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/fast/multicol/span/inside-float-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 8 months ago (2015-04-21 17:40:36 UTC) #1
dsinclair
lgtm
5 years, 8 months ago (2015-04-21 18:39:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100823002/1
5 years, 8 months ago (2015-04-21 18:39:53 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 18:57:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194152

Powered by Google App Engine
This is Rietveld 408576698