Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 1100823002: [New Multicolumn] Disallow spanners inside floats and absolutely positioned boxes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/multicol/span/inside-float-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutMultiColumnFlowThread.cpp
diff --git a/Source/core/layout/LayoutMultiColumnFlowThread.cpp b/Source/core/layout/LayoutMultiColumnFlowThread.cpp
index 80850ec8c1f9e36dbf369fcceb8744162b1e462a..140661c0ea02ca9ccbbfcd0614d4ba8ca392da1a 100644
--- a/Source/core/layout/LayoutMultiColumnFlowThread.cpp
+++ b/Source/core/layout/LayoutMultiColumnFlowThread.cpp
@@ -387,6 +387,13 @@ bool LayoutMultiColumnFlowThread::descendantIsValidColumnSpanner(LayoutObject* d
// undesirable. The spec has nothing to say on the matter.
return false; // Ignore nested spanners.
}
+ if (ancestor->isFloatingOrOutOfFlowPositioned()) {
+ // TODO(mstensho): It could actually be nice to support this (although the usefulness is
+ // probably very limited), but currently our column balancing algorithm gets confused
+ // when a spanner is inside a float, because a float's position isn't always known until
+ // after layout. Similarly for absolutely positioned boxes.
+ return false;
+ }
if (ancestor->isUnsplittableForPagination())
return false;
}
« no previous file with comments | « LayoutTests/fast/multicol/span/inside-float-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698