Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1100773003: DM: failure to canary a sink is now fatal. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
Tom Hudson, borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: failure to canary a sink is now fatal. This requires we remove NVPR from the default set of configs, as we only find out at runtime that it's not available. All the other defaults will either be compiled in and supported, or not compiled in and non-fatally skipped as unknown configs. BUG=skia: Committed: https://skia.googlesource.com/skia/+/05641a5582bbb3ee40dc2c9ba21d837df9340583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M dm/DM.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mtklein_C
5 years, 8 months ago (2015-04-21 17:29:01 UTC) #2
borenet
LGTM. I suspect we'll see lots of failures from this. May want to warn the ...
5 years, 8 months ago (2015-04-21 17:31:01 UTC) #3
mtklein
Things may blow up a little Tom.
5 years, 8 months ago (2015-04-21 17:32:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100773003/1
5 years, 8 months ago (2015-04-21 17:37:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/05641a5582bbb3ee40dc2c9ba21d837df9340583
5 years, 8 months ago (2015-04-21 17:49:17 UTC) #8
tomhudson
5 years, 8 months ago (2015-04-21 17:54:22 UTC) #9
Message was sent while issue was closed.
Thanks for the warning; I'm out of training and will come watch the tree burn.

Powered by Google App Engine
This is Rietveld 408576698