Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: dm/DM.cpp

Issue 1100773003: DM: failure to canary a sink is now fatal. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/flags/SkCommonFlags.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index ff9dc572643f821c3e189d5771f4612cefbe9a59..c0fccaaa2c7bfcee54624fb32f02af5f4771161a 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -300,8 +300,8 @@ static void push_sink(const char* tag, Sink* s) {
SkString log;
Error err = sink->draw(noop, &bitmap, &stream, &log);
if (err.isFatal()) {
- SkDebugf("Skipping %s: %s\n", tag, err.c_str());
- return;
+ SkDebugf("Could not run %s: %s\n", tag, err.c_str());
+ exit(1);
}
Tagged<Sink>& ts = gSinks.push_back();
« no previous file with comments | « no previous file | tools/flags/SkCommonFlags.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698