Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp - Issue 1100223003: bindings: Add empty checks for toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

diff --git a/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp b/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

index 151a07197df87c3ee45bea9f29d3c9275ff2c828..e169e69a840e4163fa06651e90f58615db88fd93 100644

--- a/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

+++ b/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

@@ -354,6 +354,8 @@ bool V8TestInterface::PrivateScript::shortMethodWithShortArgumentImplementedInPr

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> valueHandle = v8::Integer::New(scriptState->isolate(), value);

v8::Local<v8::Value> argv[] = { valueHandle };