Source/bindings/tests/results/core/V8TestObject.cpp - Issue 1100223003: bindings: Add empty checks for toV8()

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp » ('j') | Source/core/dom/DOMDataView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp

index 7b7b23e05b339412f700250ba47ca8823aa145f1..acfaae3c61af6651ae77fae169a65dd8d9e03fe2 100644

--- a/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -12763,6 +12763,8 @@ bool V8TestObject::PrivateScript::voidMethodImplementedInPrivateScriptMethod(Loc

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> *argv = 0;

ExceptionState exceptionState(ExceptionState::ExecutionContext, "voidMethodImplementedInPrivateScript", "TestObject", scriptState->context()->Global(), scriptState->isolate());

@@ -12789,6 +12791,8 @@ bool V8TestObject::PrivateScript::shortMethodImplementedInPrivateScriptMethod(Lo

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> *argv = 0;

ExceptionState exceptionState(ExceptionState::ExecutionContext, "shortMethodImplementedInPrivateScript", "TestObject", scriptState->context()->Global(), scriptState->isolate());

@@ -12819,6 +12823,8 @@ bool V8TestObject::PrivateScript::shortMethodWithShortArgumentImplementedInPriva

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> valueHandle = v8::Integer::New(scriptState->isolate(), value);

v8::Local<v8::Value> argv[] = { valueHandle };

@@ -12850,6 +12856,8 @@ bool V8TestObject::PrivateScript::stringMethodWithStringArgumentImplementedInPri

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> valueHandle = v8String(scriptState->isolate(), value);

v8::Local<v8::Value> argv[] = { valueHandle };

@@ -12881,6 +12889,8 @@ bool V8TestObject::PrivateScript::nodeMethodWithNodeArgumentImplementedInPrivate

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> valueHandle = toV8(value, scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> argv[] = { valueHandle };

@@ -12910,6 +12920,8 @@ bool V8TestObject::PrivateScript::nodeMethodWithVariousArgumentsImplementedInPri

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> documentHandle = toV8(document, scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> nodeHandle = toV8(node, scriptState->context()->Global(), scriptState->isolate());

@@ -12943,6 +12955,8 @@ bool V8TestObject::PrivateScript::methodForPrivateScriptOnlyMethod(LocalFrame* f

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

v8::Local<v8::Value> value1Handle = v8::Integer::New(scriptState->isolate(), value1);

v8::Local<v8::Value> value2Handle = v8::Integer::New(scriptState->isolate(), value2);

@@ -12975,6 +12989,8 @@ bool V8TestObject::PrivateScript::readonlyShortAttributeAttributeGetter(LocalFra

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "readonlyShortAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestObject", "readonlyShortAttribute", holder);

@@ -13004,6 +13020,8 @@ bool V8TestObject::PrivateScript::shortAttributeAttributeGetter(LocalFrame* fram

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "shortAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestObject", "shortAttribute", holder);

@@ -13033,6 +13051,8 @@ bool V8TestObject::PrivateScript::shortAttributeAttributeSetter(LocalFrame* fram

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::SetterContext, "shortAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "TestObject", "shortAttribute", holder, v8::Integer::New(scriptState->isolate(), cppValue));

@@ -13054,6 +13074,8 @@ bool V8TestObject::PrivateScript::stringAttributeAttributeGetter(LocalFrame* fra

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "stringAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestObject", "stringAttribute", holder);

@@ -13083,6 +13105,8 @@ bool V8TestObject::PrivateScript::stringAttributeAttributeSetter(LocalFrame* fra

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::SetterContext, "stringAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "TestObject", "stringAttribute", holder, v8String(scriptState->isolate(), cppValue));

@@ -13104,6 +13128,8 @@ bool V8TestObject::PrivateScript::nodeAttributeAttributeGetter(LocalFrame* frame

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "nodeAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestObject", "nodeAttribute", holder);

@@ -13131,6 +13157,8 @@ bool V8TestObject::PrivateScript::nodeAttributeAttributeSetter(LocalFrame* frame

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::SetterContext, "nodeAttribute", "TestObject", scriptState->context()->Global(), scriptState->isolate());

return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "TestObject", "nodeAttribute", holder, toV8(cppValue, scriptState->context()->Global(), scriptState->isolate()));

@@ -13152,6 +13180,8 @@ bool V8TestObject::PrivateScript::attributeForPrivateScriptOnlyAttributeGetter(L

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "attributeForPrivateScriptOnly", "TestObject", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestObject", "attributeForPrivateScriptOnly", holder);

@@ -13181,6 +13211,8 @@ bool V8TestObject::PrivateScript::attributeForPrivateScriptOnlyAttributeSetter(L

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::SetterContext, "attributeForPrivateScriptOnly", "TestObject", scriptState->context()->Global(), scriptState->isolate());

return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "TestObject", "attributeForPrivateScriptOnly", holder, v8String(scriptState->isolate(), cppValue));

@@ -13202,6 +13234,8 @@ bool V8TestObject::PrivateScript::enumForPrivateScriptAttributeGetter(LocalFrame

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::GetterContext, "enumForPrivateScript", "TestObject", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "TestObject", "enumForPrivateScript", holder);

@@ -13231,6 +13265,8 @@ bool V8TestObject::PrivateScript::enumForPrivateScriptAttributeSetter(LocalFrame

ScriptState::Scope scope(scriptState);

v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());

+ if (holder.IsEmpty())

+ return false;

ExceptionState exceptionState(ExceptionState::SetterContext, "enumForPrivateScript", "TestObject", scriptState->context()->Global(), scriptState->isolate());

return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "TestObject", "enumForPrivateScript", holder, v8String(scriptState->isolate(), cppValue));