Extract gpu line dashing to GrDashLinePathRenderer

Extract gpu line dashing to GrDashLinePathRenderer

Move line dashing logic from GrContext::drawPath to
GrDashLinePathRenderer. This makes it possible to let path renderers render arbitrary dashed paths.

End goal is to implement dashing in GrStencilAndCoverPathRenderer.

Committed: https://skia.googlesource.com/skia/+/1899651ffc459f5462aa989cd6d08507947b67e4

[Kimmo Kinnunen, 2015-04-23 12:27:37]

kkinnunen@nvidia.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com

[egdaniel, 2015-04-23 14:36:04]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@google.com

[egdaniel, 2015-04-23 14:36:05]

Adding stephan to this cl because I believe he was recently working on doing a
similar thing, so maybe he has some additional insight

[Stephen White, 2015-04-23 15:01:19]

On 2015/04/23 14:36:05, egdaniel wrote:
> Adding stephan to this cl because I believe he was recently working on doing a
> similar thing, so maybe he has some additional insight

I'm happy to let Kimmo take this on -- and I had put my patch on the back
burner, and this is most of what I had done plus more.

I haven't looked closely at this patch, but it seems like a good direction to
me.

[Stephen White, 2015-04-23 15:02:06]

On 2015/04/23 15:01:19, Stephen White wrote:
> On 2015/04/23 14:36:05, egdaniel wrote:
> > Adding stephan to this cl because I believe he was recently working on doing
a
> > similar thing, so maybe he has some additional insight
> 
> I'm happy to let Kimmo take this on -- and I had put my patch on the back
> burner, and this is most of what I had done plus more.
> 
> I haven't looked closely at this patch, but it seems like a good direction to
> me.

Here was my WIP patch for reference: https://codereview.chromium.org/1096513002/

[joshualitt, 2015-04-24 14:52:22]

On 2015/04/23 15:02:06, Stephen White wrote:
> On 2015/04/23 15:01:19, Stephen White wrote:
> > On 2015/04/23 14:36:05, egdaniel wrote:
> > > Adding stephan to this cl because I believe he was recently working on
doing
> a
> > > similar thing, so maybe he has some additional insight
> > 
> > I'm happy to let Kimmo take this on -- and I had put my patch on the back
> > burner, and this is most of what I had done plus more.
> > 
> > I haven't looked closely at this patch, but it seems like a good direction
to
> > me.
> 
> Here was my WIP patch for reference:
https://codereview.chromium.org/1096513002/

Okay, most of this patch looks fine to me, but other people who know more about
dashing have to chime in.  Specifically, for the changes to:
GrContext.cpp
GrDashLinePathRenderer(looks okay)
GrStrokeInfo.cpp
GrDashingEffect.cpp

[bsalomon, 2015-04-24 15:56:46]

lgtm with some nits.

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1370: if (is_nested_rects(target, &pipelineBuilder, color,
viewMatrix, path, strokeRec, rects)) {
nit, 100 col wraps in here.

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1437: pr = this->getPathRenderer(target, pipelineBuilder,
viewMatrix, *pathPtr, *strokeInfoPtr, false,
nit wrap

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrStrokeInfo.h
File src/gpu/GrStrokeInfo.h (right):

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:97: bool applyDash(SkPath* dst, GrStrokeInfo*
dstStrokeInfo, const SkPath& src) const;
Maybe a comment that if this returns false, then there is no dashing to apply
(but there might be stroking).

[Kimmo Kinnunen, 2015-04-27 06:12:26]

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1370: if (is_nested_rects(target, &pipelineBuilder, color,
viewMatrix, path, strokeRec, rects)) {
On 2015/04/24 15:56:46, bsalomon wrote:
> nit, 100 col wraps in here.

Done.

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1437: pr = this->getPathRenderer(target, pipelineBuilder,
viewMatrix, *pathPtr, *strokeInfoPtr, false,
On 2015/04/24 15:56:46, bsalomon wrote:
> nit wrap

Done.

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrStrokeInfo.h
File src/gpu/GrStrokeInfo.h (right):

https://codereview.chromium.org/1100073003/diff/20001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:97: bool applyDash(SkPath* dst, GrStrokeInfo*
dstStrokeInfo, const SkPath& src) const;
On 2015/04/24 15:56:46, bsalomon wrote:
> Maybe a comment that if this returns false, then there is no dashing to apply
> (but there might be stroking).

Done.

[Kimmo Kinnunen, 2015-04-27 06:14:27]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2015-04-27 06:14:28]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1100073003/#ps40001
(title: "address review comments")

[commit-bot: I haz the power, 2015-04-27 06:14:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100073003/40001

[commit-bot: I haz the power, 2015-04-27 06:18:54]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1899651ffc459f5462aa989cd6d08507947b67e4