Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator_ragel/decoder_x86_32.rl

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * Full-blown decoder for ia32 case.  Can be used to decode instruction sequence
  * and process it, but right now is only used in tests.
  *
  * The code is in [hand-written] "parse_instruction.rl" and in [auto-generated]
  * "decoder_x86_32_instruction.rl" file.  This file only includes tiny amount
  * of the glue code.
  */
 
 #include <assert.h>
 #include <stddef.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include "native_client/src/shared/utils/types.h"
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoder_internal.h"
+#include "native_client/src/trusted/validator_ragel/decoder_internal.h"
 
 /*
  * These prefixes are not useful in IA32 mode, but they will "cleaned up" by
  * decoder's cleanup procedure anyway.  Do nothing when that happens.
  */

[halyavin, 2013/03/13 15:25:33]

Remove this defines by duplicating end_of_instruction_cleanup.

[khim, 2013/03/19 14:54:46]

Done: https://codereview.chromium.org/12716018

 #define SET_REX_PREFIX(P)
 #define SET_VEX_PREFIX2(P)
 #define CLEAR_SPURIOUS_REX_B()
 #define SET_SPURIOUS_REX_B()
 #define CLEAR_SPURIOUS_REX_X()
 #define SET_SPURIOUS_REX_X()
 #define CLEAR_SPURIOUS_REX_R()
 #define SET_SPURIOUS_REX_R()
 #define CLEAR_SPURIOUS_REX_W()
 #define SET_SPURIOUS_REX_W()
@@ skipping 42 matching lines @@
     "native_client/src/trusted/validator_ragel/unreviewed/parse_instruction.rl";
 
   include decode_x86_32 "decoder_x86_32_instruction.rl";
 
   include decoder
     "native_client/src/trusted/validator_ragel/unreviewed/parse_instruction.rl";
 
   main := decoder;
 }%%
 
+/*
+ * The "write data" statement causes Ragel to emit the constant static data
+ * needed by the ragel machine.
+ */
 %% write data;
 
 int DecodeChunkIA32(const uint8_t *data, size_t size,
                     ProcessInstructionFunc process_instruction,
                     ProcessDecodingErrorFunc process_error, void *userdata) {
   const uint8_t *current_position = data;
   const uint8_t *end_of_data = data + size;
   const uint8_t *instruction_begin = current_position;
   uint8_t vex_prefix3 = 0x00;
   enum ImmediateMode imm_operand = IMMNONE;
   enum ImmediateMode imm2_operand = IMMNONE;
   struct Instruction instruction;
   int result = TRUE;
 
   int current_state;
 
   /* Not used in ia32_mode.  */
   instruction.prefix.rex = 0;

[halyavin, 2013/03/13 15:41:36]

use memset to clear instruction.

[khim, 2013/03/19 14:54:46]

Done: https://codereview.chromium.org/12716018

 
   SET_DISP_TYPE(DISPNONE);
   SET_IMM_TYPE(IMMNONE);
   SET_IMM2_TYPE(IMMNONE);
   SET_DATA16_PREFIX(FALSE);
   SET_LOCK_PREFIX(FALSE);
   SET_REPNZ_PREFIX(FALSE);
   SET_REPZ_PREFIX(FALSE);
   SET_BRANCH_NOT_TAKEN(FALSE);
   SET_BRANCH_TAKEN(FALSE);
   SET_ATT_INSTRUCTION_SUFFIX(NULL);
   instruction.prefix.rex_b_spurious = FALSE;
   instruction.prefix.rex_x_spurious = FALSE;
   instruction.prefix.rex_r_spurious = FALSE;
   instruction.prefix.rex_w_spurious = FALSE;
 
+  /*
+   * The "write init" statement causes Ragel to emit initialization code.
+   * This should be executed once before the ragel machine is started.
+   */
   %% write init;
+  /*
+   * The "write exec" statement causes Ragel to emit the ragel machine's
+   * execution code.
+   */
   %% write exec;
 
 error_detected:
   return result;
 }