Certificate Transparency: Fetching of Signed Tree Heads (DRAFT)

net/cert/ct_log_verifier_unittest.cc

Index: net/cert/ct_log_verifier_unittest.cc
diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc
index e8d1bc4e7bd299882aa5cb70d0ea105f1f05de13..7cf2b831d823714486277c415f67f0837dd13696 100644
--- a/net/cert/ct_log_verifier_unittest.cc
+++ b/net/cert/ct_log_verifier_unittest.cc
@@ -19,7 +19,7 @@ class CTLogVerifierTest : public ::testing::Test {
   CTLogVerifierTest() {}
 
   void SetUp() override {
-    log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog").Pass();
+    log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog", "").Pass();

[Ryan Sleevi, 2015/04/24 10:42:08]

s/""/std::string()

[Eran Messeri, 2015/06/18 15:18:42]

Done.

 
     ASSERT_TRUE(log_);
     ASSERT_EQ(log_->key_id(), ct::GetTestPublicKeyId());
@@ -79,14 +79,14 @@ TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
 TEST_F(CTLogVerifierTest, SetsValidSTH) {
   scoped_ptr<ct::SignedTreeHead> sth(new ct::SignedTreeHead());
   ct::GetSignedTreeHead(sth.get());
-  ASSERT_TRUE(log_->SetSignedTreeHead(sth.Pass()));
+  ASSERT_TRUE(log_->VerifySignedTreeHead(sth.get()));

[Ryan Sleevi, 2015/04/24 10:42:08]

no need for .get() for scoped_ptr's; it's cleaner that way.

[Eran Messeri, 2015/06/18 15:18:42]

Done.

 }
 
 TEST_F(CTLogVerifierTest, DoesNotSetInvalidSTH) {
   scoped_ptr<ct::SignedTreeHead> sth(new ct::SignedTreeHead());
   ct::GetSignedTreeHead(sth.get());
   sth->sha256_root_hash[0] = '\x0';
-  ASSERT_FALSE(log_->SetSignedTreeHead(sth.Pass()));
+  ASSERT_FALSE(log_->VerifySignedTreeHead(sth.get()));
 }
 
 // Test that excess data after the public key is rejected.
@@ -94,7 +94,7 @@ TEST_F(CTLogVerifierTest, ExcessDataInPublicKey) {
   std::string key = ct::GetTestPublicKey();
   key += "extra";
 
-  scoped_ptr<CTLogVerifier> log = CTLogVerifier::Create(key, "testlog");
+  scoped_ptr<CTLogVerifier> log = CTLogVerifier::Create(key, "testlog", "");

[Ryan Sleevi, 2015/04/24 10:42:08]

s/""/std::string()

[Eran Messeri, 2015/06/18 15:18:42]

Done.

   EXPECT_FALSE(log);
 }