Certificate Transparency: Fetching of Signed Tree Heads (DRAFT)

net/cert/ct_log_verifier_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_log_verifier.h"
 
 #include <string>
 
 #include "base/time/time.h"
 #include "net/cert/signed_certificate_timestamp.h"
 #include "net/cert/signed_tree_head.h"
 #include "net/test/ct_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 class CTLogVerifierTest : public ::testing::Test {
  public:
   CTLogVerifierTest() {}
 
   void SetUp() override {
-    log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog").Pass();
+    log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog", "").Pass();

[Ryan Sleevi, 2015/04/24 10:42:08]

s/""/std::string()

[Eran Messeri, 2015/06/18 15:18:42]

Done.

 
     ASSERT_TRUE(log_);
     ASSERT_EQ(log_->key_id(), ct::GetTestPublicKeyId());
   }
 
  protected:
   scoped_ptr<CTLogVerifier> log_;
 };
 
 TEST_F(CTLogVerifierTest, VerifiesCertSCT) {
@@ skipping 39 matching lines @@
   // Mangle the log ID, which should cause it to match a different log before
   // attempting signature validation.
   cert_sct->log_id.assign(cert_sct->log_id.size(), '\0');
 
   EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct.get()));
 }
 
 TEST_F(CTLogVerifierTest, SetsValidSTH) {
   scoped_ptr<ct::SignedTreeHead> sth(new ct::SignedTreeHead());
   ct::GetSignedTreeHead(sth.get());
-  ASSERT_TRUE(log_->SetSignedTreeHead(sth.Pass()));
+  ASSERT_TRUE(log_->VerifySignedTreeHead(sth.get()));

[Ryan Sleevi, 2015/04/24 10:42:08]

no need for .get() for scoped_ptr's; it's cleaner that way.

[Eran Messeri, 2015/06/18 15:18:42]

Done.

 }
 
 TEST_F(CTLogVerifierTest, DoesNotSetInvalidSTH) {
   scoped_ptr<ct::SignedTreeHead> sth(new ct::SignedTreeHead());
   ct::GetSignedTreeHead(sth.get());
   sth->sha256_root_hash[0] = '\x0';
-  ASSERT_FALSE(log_->SetSignedTreeHead(sth.Pass()));
+  ASSERT_FALSE(log_->VerifySignedTreeHead(sth.get()));
 }
 
 // Test that excess data after the public key is rejected.
 TEST_F(CTLogVerifierTest, ExcessDataInPublicKey) {
   std::string key = ct::GetTestPublicKey();
   key += "extra";
 
-  scoped_ptr<CTLogVerifier> log = CTLogVerifier::Create(key, "testlog");
+  scoped_ptr<CTLogVerifier> log = CTLogVerifier::Create(key, "testlog", "");

[Ryan Sleevi, 2015/04/24 10:42:08]

s/""/std::string()

[Eran Messeri, 2015/06/18 15:18:42]

Done.

   EXPECT_FALSE(log);
 }
 
 }  // namespace net