Certificate Transparency: Fetching of Signed Tree Heads (DRAFT)

chrome/browser/io_thread.cc

Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 34fe6b88f55660e46a3825624e5e9534e4297f89..e82d96adcf78410f36c007d8557bda09a7bbbc08 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -40,6 +40,8 @@
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
+#include "components/certificate_transparency/log_proofs_fetcher.h"
+#include "components/certificate_transparency/new_scts_observer.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/policy/core/common/policy_service.h"
@@ -738,7 +740,7 @@ void IOThread::InitAsync() {
                                &ct_public_key_data))
           << "Unable to decode CT public key.";
       scoped_ptr<net::CTLogVerifier> external_log_verifier(
-          net::CTLogVerifier::Create(ct_public_key_data, log_description));
+          net::CTLogVerifier::Create(ct_public_key_data, log_description, ""));

[Ryan Sleevi, 2015/04/24 10:42:05]

s/""/std::string()/

[Eran Messeri, 2015/06/18 15:18:40]

Obsolete.

       CHECK(external_log_verifier) << "Unable to parse CT public key.";
       VLOG(1) << "Adding log with description " << log_description;
       ct_verifier->AddLog(external_log_verifier.Pass());
@@ -896,6 +898,12 @@ void IOThread::InitAsync() {
   globals_->proxy_script_fetcher_context.reset(
       ConstructProxyScriptFetcherContext(globals_, net_log_));
 
+  certificate_transparency::NewSCTsObserver* scts_observer =

[Ryan Sleevi, 2015/04/24 10:42:05]

LEAK/DESIGN: Where does this ever get deleted?

If AddObserver takes ownership, than RemoveObserver becomes a dangerous API
(since the pointer may have been deleted by AddObserver's implementation
whenever it wants, so it's not safe for the caller to hold on to the pointer).

I think (having only read header files thus far) that AddObserver *doesn't* take
ownership, in which case, this is a leak.

[Eran Messeri, 2015/06/18 15:18:40]

Per design discussion over email, the observer is now owned by the IOThread
globals and gets deleted before the URLRequestContext.
To prevent the CTVerifier from invoking it after it was deleted (but before the
CTVerifier itself was deleted) I've added a StopNotifying method to the
CTVerifier which causes it to nullify the pointer.

+      new certificate_transparency::NewSCTsObserver(
+          new certificate_transparency::LogProofsFetcher(
+              globals_->system_request_context.get()));
+  ct_verifier->AddObserver(scts_observer);
+
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   // Start observing Keychain events. This needs to be done on the UI thread,
   // as Keychain services requires a CFRunLoop.