Certificate Transparency: Fetching of Signed Tree Heads (DRAFT)

chrome/browser/io_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/io_thread.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 22 matching lines @@
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/net/connect_interceptor.h"
 #include "chrome/browser/net/dns_probe_service.h"
 #include "chrome/browser/net/pref_proxy_config_tracker.h"
 #include "chrome/browser/net/proxy_service_factory.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
+#include "components/certificate_transparency/log_proofs_fetcher.h"
+#include "components/certificate_transparency/new_scts_observer.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/policy/core/common/policy_service.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "net/base/host_mapping_rules.h"
 #include "net/base/net_util.h"
 #include "net/base/sdch_manager.h"
 #include "net/cert/cert_policy_enforcer.h"
@@ skipping 678 matching lines @@
       size_t delim_pos = curr_log.find(":");
       CHECK(delim_pos != std::string::npos)
           << "CT log description not provided (switch format"
              " is 'description:base64_key')";
       std::string log_description(curr_log.substr(0, delim_pos));
       std::string ct_public_key_data;
       CHECK(base::Base64Decode(curr_log.substr(delim_pos + 1),
                                &ct_public_key_data))
           << "Unable to decode CT public key.";
       scoped_ptr<net::CTLogVerifier> external_log_verifier(
-          net::CTLogVerifier::Create(ct_public_key_data, log_description));
+          net::CTLogVerifier::Create(ct_public_key_data, log_description, ""));

[Ryan Sleevi, 2015/04/24 10:42:05]

s/""/std::string()/

[Eran Messeri, 2015/06/18 15:18:40]

Obsolete.

       CHECK(external_log_verifier) << "Unable to parse CT public key.";
       VLOG(1) << "Adding log with description " << log_description;
       ct_verifier->AddLog(external_log_verifier.Pass());
     }
   }
 
   // TODO(erikchen): Remove ScopedTracker below once http://crbug.com/466432
   // is fixed.
   tracked_objects::ScopedTracker tracking_profile10(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
@@ skipping 137 matching lines @@
   globals_->proxy_script_fetcher_url_request_job_factory = job_factory.Pass();
 
   globals_->throttler_manager.reset(new net::URLRequestThrottlerManager());
   globals_->throttler_manager->set_net_log(net_log_);
   // Always done in production, disabled only for unit tests.
   globals_->throttler_manager->set_enable_thread_checks(true);
 
   globals_->proxy_script_fetcher_context.reset(
       ConstructProxyScriptFetcherContext(globals_, net_log_));
 
+  certificate_transparency::NewSCTsObserver* scts_observer =

[Ryan Sleevi, 2015/04/24 10:42:05]

LEAK/DESIGN: Where does this ever get deleted?

If AddObserver takes ownership, than RemoveObserver becomes a dangerous API
(since the pointer may have been deleted by AddObserver's implementation
whenever it wants, so it's not safe for the caller to hold on to the pointer).

I think (having only read header files thus far) that AddObserver *doesn't* take
ownership, in which case, this is a leak.

[Eran Messeri, 2015/06/18 15:18:40]

Per design discussion over email, the observer is now owned by the IOThread
globals and gets deleted before the URLRequestContext.
To prevent the CTVerifier from invoking it after it was deleted (but before the
CTVerifier itself was deleted) I've added a StopNotifying method to the
CTVerifier which causes it to nullify the pointer.

+      new certificate_transparency::NewSCTsObserver(
+          new certificate_transparency::LogProofsFetcher(
+              globals_->system_request_context.get()));
+  ct_verifier->AddObserver(scts_observer);
+
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   // Start observing Keychain events. This needs to be done on the UI thread,
   // as Keychain services requires a CFRunLoop.
   BrowserThread::PostTask(BrowserThread::UI,
                           FROM_HERE,
                           base::Bind(&ObserveKeychainEvents));
 #endif
 
   // InitSystemRequestContext turns right around and posts a task back
   // to the IO thread, so we can't let it run until we know the IO
@@ skipping 716 matching lines @@
   net::QuicVersionVector supported_versions = net::QuicSupportedVersions();
   for (size_t i = 0; i < supported_versions.size(); ++i) {
     net::QuicVersion version = supported_versions[i];
     if (net::QuicVersionToString(version) == quic_version) {
       return version;
     }
   }
 
   return net::QUIC_VERSION_UNSUPPORTED;
 }