Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100003005: ServiceWorker: Cleanup ServiceWorkerVersion (Closed)

Created:
5 years, 8 months ago by nhiroki
Modified:
5 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Cleanup ServiceWorkerVersion - Remove unused friendliness - Remove DCHECK and if-statement combination forbidden by our coding standard http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED- - Make some instance variables const BUG=n/a TEST=n/a Committed: https://crrev.com/e35f298614dce54a81c87ad36e2ca265c95a4675 Cr-Commit-Position: refs/heads/master@{#326740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M content/browser/service_worker/service_worker_version.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
PTAL, thanks!
5 years, 8 months ago (2015-04-24 02:10:44 UTC) #2
falken
lgtm, thanks for these cleanups
5 years, 8 months ago (2015-04-24 02:15:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100003005/1
5 years, 8 months ago (2015-04-24 03:44:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 04:31:48 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 04:32:44 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e35f298614dce54a81c87ad36e2ca265c95a4675
Cr-Commit-Position: refs/heads/master@{#326740}

Powered by Google App Engine
This is Rietveld 408576698